Lint: Fix [301] Commands should not change things if nothing needs doing
#1139
Conversation
roles/common/tasks/reload_nginx.yml
Outdated
| @@ -2,6 +2,7 @@ | |||
| - name: reload nginx | |||
| command: nginx -t | |||
| notify: "{{ (role_path | basename == 'common') | ternary('perform nginx reload', omit) }}" | |||
| changed_when: false | |||
There was a problem hiding this comment.
🤔 I think this is breaking things. Both in production and with Vagrant Nginx isn't reloading and you just get the default Nginx page. I'll test without it.
There was a problem hiding this comment.
Yep this prevents nginx from actually reloading
There was a problem hiding this comment.
Looks like we need changed_when: true to trigger notify. See: https://serverfault.com/a/799282
There was a problem hiding this comment.
We still need this as changed_when: true true? Which I'm guessing fails the lint... any idea what the solution is?
There was a problem hiding this comment.
changed_when: true passes ansible-lint and triggers nginx reload. Tested use cases:
vargant upthe first time- change site domains and then
vagrant provision
There was a problem hiding this comment.
It leads to the question that should we changed_when: true on other tasks:
Get list position of current symlinked release: No because it doesn't change anythingCollect list of releases: No because it doesn't change anythingGet name of current symlinked release: No because it doesn't change anythingCreate or close Xdebug SSH tunnel: Yes because it changes the tunnel. See: 78ebc81
tangrufus
force-pushed
the
lint-301
branch
2 times, most recently
from
3add785 to
fec1a48
Compare
tangrufus
changed the title
[301] Commands should not change things if nothing needs doing[301] Commands should not change things if nothing needs doing
tangrufus
changed the title
[301] Commands should not change things if nothing needs doing[301] Commands should not change things if nothing needs doing
No description provided.