Improve ip_whitelist in development #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalkinshaw
force-pushed
the
improve-ip-whitelist
branch
2 times, most recently
from
11fdaf6 to
4b9beb3
Compare
Fixes #1181 `ansible_default_ipv4.gateway` wasn't a good default as it wasn't the actual Vagrant external IP (`192.168.50.5`). `ansible_all_ipv4_addresses` is the replacement which includes that IP. This also moves the development specific override to the proper development config.
swalkinshaw
force-pushed
the
improve-ip-whitelist
branch
from
4b9beb3 to
2ba823f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1181
ansible_default_ipv4.gatewaywasn't a good default as it wasn't the actual Vagrant external IP (192.168.50.5).ansible_all_ipv4_addressesis the replacement which includes that IP.This also moves the development specific override to the proper development config.