Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split is-installed check into a non-multisite and a mulitsite specific one #1388

Merged
merged 6 commits into from
Jun 1, 2022
Merged

Split is-installed check into a non-multisite and a mulitsite specific one #1388

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c2f6eeb
Split is installed check into a non-multisite and a mulitsite specifi…
strarsis May 31, 2022
49d95c9
Fix `when` for defining variable used in multisite-specific check.
strarsis Jun 1, 2022
4952e88
Group "WordPress Installed" non-multisite and multisite tasks into An…
strarsis Jun 1, 2022
2f1cfe0
Fix when lines.
strarsis Jun 1, 2022
e1e82a8
Make `strpos` `empty needle` PHP warning match less strict (omit line…
strarsis Jun 1, 2022
8edc250
Improve task names (invoke).
strarsis Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 45 additions & 3 deletions roles/deploy/hooks/finalize-before.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,58 @@
---
# Is installed check
# Non-multisite specific check
- name: WordPress Installed (non-multisite)?
command: wp core is-installed --skip-plugins --skip-themes
args:
chdir: "{{ deploy_helper.new_release_path }}"
register: wp_installed_single
changed_when: false
failed_when: wp_installed_single.stderr | length > 0 or wp_installed_single.rc > 1
when:
- not project.multisite.enabled | default(false)

# Multisite specific check
- name: Create file with multisite constants defined as false
copy:
src: "tmp_multisite_constants.php"
dest: "{{ deploy_helper.shared_path }}/tmp_multisite_constants.php"
when:
- project.multisite.enabled | default(false)

- name: Set variables used in "WordPress Installed?" check
set_fact:
php_needle_warning: "Warning: strpos\\(\\): Empty needle in {{ deploy_helper.new_release_path }}/web/wp/wp-includes/link-template.php on line 3535"
when:
#- project.multisite.enabled | default(false)
strarsis marked this conversation as resolved.
Show resolved Hide resolved
- not project.multisite.enabled | default(false)

- name: WordPress Installed?
- name: WordPress Installed (multisite)?
command: wp core is-installed --skip-plugins --skip-themes --require={{ deploy_helper.shared_path }}/tmp_multisite_constants.php
args:
chdir: "{{ deploy_helper.new_release_path }}"
register: wp_installed
register: wp_installed_multisite
changed_when: false
failed_when: wp_installed.stderr | default("") != "" or wp_installed.rc > 1
failed_when: (wp_installed_multisite.stderr | length > 0 and wp_installed_multisite.stderr is not match(php_needle_warning)) or wp_installed_multisite.rc > 1
when:
- project.multisite.enabled | default(false)
# /Multisite specific check

# Because variable is always registered, even with non-applying when-condition
- name: Set "WordPress installed (non-multisite)?" result variable
set_fact:
wp_installed: "{{ wp_installed_single }}"
when:
- not project.multisite.enabled | default(false)

- name: Set "WordPress installed (multisite)?" result variable
set_fact:
wp_installed: "{{ wp_installed_multisite }}"
when:
- project.multisite.enabled | default(false)
# /Is installed check




- name: Get WP theme template and stylesheet roots
shell: >
Expand Down