-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vagrant provider agnostic setup #340
Conversation
when /darwin/ then `sysctl -n hw.ncpu`.to_i | ||
when /linux/ then `nproc`.to_i | ||
else 2 | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you restore this formatting/indentation to what it was?
@ckovey thanks for this. Just had a couple minor style issues. Would you be able to squash commits once it's ready? |
81e76dc
to
4e72c47
Compare
Fixed style issues and squashed everything up, sorry about that @swalkinshaw ! |
Wanna add VMware fusion while we are at it? I have a license I can test with. |
@austinpray would you mind trying it as is? Supposedly the different VMware provider names were unified into |
@ckovey I see! I'll test it tomorrow then |
c41fc19
to
145c31c
Compare
I changed the box url to use the override way of doing things in their example: https://docs.vagrantup.com/v2/providers/configuration.html. Then it seemed like Finally DRY'd the memory setting out to be with CPU setting. Tested this on my Win 8 VMware and MBP with Virtualbox. I don't have fusion if you want to try again |
@ckovey looks great. We'll eventually need to add some documentation that we support other providers now but this is still good for now. |
@ckovey could you rebase this? should be good to go after that. |
f615efa
to
10455bb
Compare
@swalkinshaw rebased, thanks. Looks like someone figured out how to get Windows CPU count, nice! |
Does this mean Trellis can work with Parallels? |
@merchantguru it should. |
Parallels works with a few tweaks. Errors I got:
Using
I changed Not sure if you'd want to make a change like that to the default Trellis Vagrantfile or what. |
Rather than throwing an error for non-Virtualbox users, setup the additional providers. Neither the Ubuntu or Hashicorp Atlas users provide boxes for VMWare or Parallels so we must fall back to a no configuraiton management box provided by Puppet Labs For Windows users using a non-standard provider/box like VMWare we must check that add-apt-repository is installed before trying to use it
Thanks @merchantguru, I did not have Parallels to test so I just made an assumption with the box. I've updated the commit with the re the IP error. This I believe is because you have multiple Trellis installations going or some other device/VM on that IP in your network. The master version of |
@merchantguru awesome, thanks for testing. I agree about the networking error. Unless that error would happen on a standard first Trellis install then we shouldn't worry about it. |
OK @ckovey, @swalkinshaw, I've retested and Parallels works flawlessly. Thanks for making this provider agnostic! |
Vagrant provider agnostic setup
@ckovey thanks for this! |
This allows Trellis to be provider agnostic without losing any functionality. I've tested on Windows 8.1 with VMWare Workstation 11 using Vagrant 1.7.4