Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass cli options to user role's admin_user ping test #582

Merged
merged 1 commit into from
May 7, 2016

Conversation

fullyint
Copy link
Contributor

@fullyint fullyint commented May 6, 2016

When #578 added connection-related CLI options to the remote-user role's ping command, it probably should have also updated the users role's ping command (introduced in #345). Here is a discourse thread demonstrating the need for this fix.

This PR:

  • applies Add connection-related cli options to ping command #578's cli_options_ping to the users role
  • removes --user from cli_options_ping, adjusting each task to specify user explicitly, given that the two different ping tests rely on different users
  • adds a default for the cli_options_ping variable as a safety in case vars_plugins ever happened to be disabled, in which case the var would be undefined

@swalkinshaw
Copy link
Member

👍

@swalkinshaw swalkinshaw merged commit 30ec2d9 into roots:master May 7, 2016
@fullyint fullyint deleted the cli-options-ping branch May 7, 2016 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants