Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom current_path #607

Merged
merged 1 commit into from
Jul 19, 2016
Merged

Allow custom current_path #607

merged 1 commit into from
Jul 19, 2016

Conversation

cfxd
Copy link
Contributor

@cfxd cfxd commented Jun 30, 2016

def remote_site_path(site_name)
"/srv/www/#{site_name}/current"
def remote_site_path(site_name, site)
"/srv/www/#{site_name}/#{current_path = site['current_path'] || 'current'}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for assignment here. just: "/srv/www/#{site_name}/#{site['current_path'] || 'current'}"

@swalkinshaw
Copy link
Member

There's one more instance of current to change after #616

Remove Vagrantfile assignment

Define project_current_path in roles/deploy/defaults/main.yml instead of deploy.yml (also change var name to match convention

Ensure rollback role gets project_current_path var

Neater var order

Even better, shorter vars

Change path after merge of #616

Add changelog entry
@@ -9,6 +9,7 @@

vars:
project_root: "{{ www_root }}/{{ site }}"
project_current_path: "{{ wordpress_sites[site].current_path | default('current') }}"
Copy link
Contributor Author

@cfxd cfxd Jul 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fix for the rollback role

@swalkinshaw
Copy link
Member

👍

@swalkinshaw swalkinshaw merged commit 263eb22 into roots:master Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants