Nginx includes: Move templates dir, fix 'No such file' error #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2016
fullyint
force-pushed
the
nginx-includes
branch
from
b53eefc to
91ea970
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #517, preventing the message that occurs if users have no Nginx includes templates:
roles/wordpress-setup/templates/includes.d: No such file or directory.Docs in roots/docs#57
What changes for users?
nginx-includes(directory name configurable vianginx_includes_templates_path).nginx_includes_d_cleanup: falseto prevent Trellis from removing unmanaged confs from remote.More possibilities and options will come in the Nginx hooks PR #688. For example, the current Nginx includes are limited in that files can only be included in one spot within the conf, within the site's primary
serverblock. #688 will make it possible add lines or includes elsewhere (outsideserverblock, etc.).