-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vagrant: Support DHCP #892
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think we'll probably merge this since it's fairly simple and optional.
Vagrantfile
Outdated
config.vm.network :private_network, type: 'dhcp', hostsupdater: 'skip' | ||
|
||
cached_addresses = {} | ||
config.hostmanager.ip_resolver = proc do |vm, resolving_vm| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small thing, but prefix resolving_vm
with _
since it's unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
We may even want to make dhcp the default. Seems simpler? |
👍 for default However, if you already have a VM with static IP (running / poweroff doesn't matter), you need |
I think just |
I had trouble with |
I tested this over at Drupal VM and same happened for me if you're referring to a |
I got more errors besides Just curious: Do you work while travelling, @oxyc? I found it extremely hard to stay in front of the computer when everyone else in the hostel went out for sun and beach. |
For reference the plugins I had were @tangrufus Nah I never liked mixing work and travel, wouldn't do either at full capacity. I usually travel 4-6 months until I get sick of it, then find a place to work for 6-8 months until I miss it again, and repeat. Also I like signing off so I don't want to bring my laptop. |
Allow running multiple Trellis machines at the same time.
Tested with 2 DHCP machines and 1 static IP machine running at the same time. Results:
The
ip_resolver
proc is taken from devopsgroup-io/vagrant-hostmanager#86 (comment)Related #295 (comment)
Closes #873