Disable memcached UDP support by default #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm Optionally could make it a default var |
swalkinshaw
force-pushed
the
memcached-disable-udp
branch
from
d40445e to
7ea7be1
Compare
memcached can be exploited via UDP. This disables it by default. See https://blog.cloudflare.com/memcrashed-major-amplification-attacks-from-port-11211/ form more details.
swalkinshaw
force-pushed
the
memcached-disable-udp
branch
from
7ea7be1 to
e07a2b3
Compare
|
Oh I meant to do that. Added. Also added changelog entry. This is technically a breaking change although I doubt anyone is actually using the UDP feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memcached can be exploited via UDP. This disables it by default.
See https://blog.cloudflare.com/memcrashed-major-amplification-attacks-from-port-11211/
form more details.