Enable nginx to start on boot #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How do you want to go about testing this, @fullyint? |
fullyint
approved these changes
Apr 24, 2018
There was a problem hiding this comment.
LGTM
This works for me on Ansible 2.2.0.0 (no longer supported by Trellis), 2.4.0.0 (minimum supported), and 2.5.1.0 (latest Ansible). It also seems to work fine on Ubuntu 16.04.3 and 16.04.4. I didn't try to get a hold of older releases. Worked for me on latest bento/ubuntu-16.04vagrant box with ansible on host or ansible_local on guest.
@nathanielks Could you add CHANGELOG entry? Should be good to go.
fullyint
force-pushed
the
enable-nginx-service
branch
from
9877d76 to
5bcbd32
Compare
|
@fullyint my apologies, this got buried in my inbox. Thanks for the assist! |
6 tasks
greatislander
pushed a commit
to pressbooks/trellis
that referenced
this pull request
Jun 7, 2018
* Add xdebug.remote_autostart to simplify xdebug sessions * Update logrotate doc URL [ci skip] * Update WP-CLI to 1.5.1. * Update changelog. [ci skip] * Update geerlingguy.composer 1.6.1->1.7.0 (roots#983) Update from `1.6.1` -> `1.7.0` which addresses roots#943 ([DEPRECATION WARNING]: The use of 'include' for tasks has been deprecated.) * Update geerlingguy.ntp 1.5.2->1.6.0 (roots#984) Avoids deprecation warnings introduced in Ansible 2.4: "The use of 'include' for tasks has been deprecated." * Enable nginx to start on boot (roots#980) * update changelog * 'yarn run' -> 'yarn' [ci skip] * Issue warning for all Ubuntu releases that are not Xenial (roots#986) * Clarify that changelog entry indicates Trellis version (roots#987) * Validate python version on control machine (roots#988) * Common: Install `git` instead of `git-core` Because `git-core` is now a dummy package of `git`. See: http://git.661346.n2.nabble.com/git-core-vs-git-package-on-ubuntu-tp7576083p7576085.html * Add CSP frame-ancestors, make X-Frame-Options conditional (roots#977) The X-Frame-Options header has been obsoleted by the frame-ancestors directive. Retain the X-Frame-Options header for older browsers. Return empty X-Frame-Options header for WordPress Customizer content to prevent the conflict that SAMEORIGIN would have with the ALLOW-FROM option that WordPress adds on its own (Safari browser). Discussion in https://core.trac.wordpress.org/ticket/40020 * Improve failed_when rule for Wordpress Installed check (roots#991) In rare cases the wp_installed registered var may be missing the stderr attribute, so add a default to avoid related error. The `wp core is-installed` command return code is 1 if WP is simply not installed. However, in rare cases the command may return some other return code indicative of true failure, so fail if rc > 1. * deploy.sh: Return non-zero exit code when misuse (roots#990) - Exit with `127` when not enough arguments - Exit with `1` when hosts file not exist See: http://www.tldp.org/LDP/abs/html/exitcodes.html * Skip Acme Challenge failure message for non-failed sites (roots#993) * Bump Ansible version_tested_max to 2.5.3 (roots#981) * Bump Ansible version_tested_max to 2.5.3 Convert Jinja2 tests from filter format to `var is testname` format. Encourage users on Ansible 2.5.0 to upgrade to avoid erroneous warnings fixed in ansible/ansible 37538 * Add option to enable FastCGI background updates (roots#962) Enabled by default * Add quotes to nginx_cache_background_update value "on" Quotes prevent Ansible from interpolating the variable value as True. True is an invalid value for fastcgi_cache_background_update and would would make Nginx unable to reload. * Verify `wp-cli.phar` checksum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nginx service isn't enabled, so it doesn't automatically start on
boot. Fixes #979