Skip to content

Commit

Permalink
Update cran comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Robinlovelace committed Aug 19, 2022
1 parent 824a9b2 commit 436e855
Showing 1 changed file with 4 additions and 16 deletions.
20 changes: 4 additions & 16 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,9 @@
Update: I have updated faulty URLs and removed the .onLoad message to prevent NOTEs.

Please double check if there are more notes: the DOI related note is a false positive.

This is a major update removing support for objects with classes based on the sp package.

sp has be superseded by sf. This change prepares for the retirement of sp and associated packages.

The package retains an onload message preparing people for this major change. I could remove it but suspect the benefits of keeping the onload message for this release, to be removed on the next release, outweigh the cons.

Happy for any comments on this.
Fixed URLs

## R CMD check results
checking R code for possible problems ... NOTE
File ‘stplanr/R/zzz.R’:
.onLoad calls:

0 errors ✔ | 0 warnings ✔ | 1 notes ✖
checking R code for possible problems ... NOTE File 'stplanr/R/zzz.R': .onLoad calls:

R CMD check succeeded
0 errors ✔ \| 0 warnings ✔ \| 1 notes ✖

R CMD check succeeded

0 comments on commit 436e855

Please sign in to comment.