Fixing linking issue with service_client_imp.h #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
fujitatomoya
approved these changes
Feb 5, 2021
|
Thanks @yuriy228! Given that the changes have been approved, could you please merge them in? |
|
@PrajishKumar, cannot do this due to not having writting rights to the repo. |
|
+1 |
|
Any maintainers that can merge this? @mjcarroll / @jacobperron |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
service_client_imp.h has definition (implementation) of two not-template, not-inline functions:
bool ServiceClient::waitForServer(const ros::Duration & timeout)
bool ServiceClient::isServerConnected()
This provides an issue when including action lib headers (that includes this header) in several .cpp's within one project (one executable/library). The linker then reports function implementation duplication error (which is not surprising).
The proposal is to define the functions as inline.