Proxy config to ChromeForTestingClient added (#259)

rosolko · Aug 9, 2023 · e0ceb46 · e0ceb46
1 parent 0db1785
commit e0ceb46
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 7 deletions.
diff --git a/WebDriverManager/Clients/ChromeForTestingClient.cs b/WebDriverManager/Clients/ChromeForTestingClient.cs
@@ -1,4 +1,5 @@
 using System;
+using System.Net;
 using System.Net.Http;
 using System.Text.Json;
 using System.Threading.Tasks;
@@ -14,27 +15,40 @@ public static class ChromeForTestingClient
             PropertyNameCaseInsensitive = true
         };
 
-        private static readonly HttpClient _httpClient;
+        private static HttpClient _httpClient;
 
-        static ChromeForTestingClient()
+        private static HttpClient HttpClient
         {
-            _httpClient = new HttpClient
+            get
             {
-                BaseAddress = new Uri(BaseUrl)
-            };
+                var handler = new HttpClientHandler
+                {
+                    UseProxy = Proxy != null,
+                    Proxy = Proxy
+                };
+
+                _httpClient = new HttpClient(handler)
+                {
+                    BaseAddress = new Uri(BaseUrl)
+                };
+
+                return _httpClient;
+            }
         }
 
+        public static IWebProxy Proxy { get; set; }
+
         public static ChromeVersions GetKnownGoodVersionsWithDownloads()
         {
             return GetResultFromHttpTask<ChromeVersions>(
-                _httpClient.GetAsync("known-good-versions-with-downloads.json")
+                HttpClient.GetAsync("known-good-versions-with-downloads.json")
             );
         }
 
         public static ChromeVersions GetLastKnownGoodVersions()
         {
             return GetResultFromHttpTask<ChromeVersions>(
-                _httpClient.GetAsync("last-known-good-versions-with-downloads.json")
+                HttpClient.GetAsync("last-known-good-versions-with-downloads.json")
             );
         }
 

diff --git a/WebDriverManager/DriverManager.cs b/WebDriverManager/DriverManager.cs
@@ -1,6 +1,7 @@
 using System;
 using System.IO;
 using System.Net;
+using WebDriverManager.Clients;
 using WebDriverManager.DriverConfigs;
 using WebDriverManager.Helpers;
 using WebDriverManager.Services;
@@ -36,6 +37,7 @@ public DriverManager(IBinaryService binaryService, IVariableService variableServ
         public DriverManager WithProxy(IWebProxy proxy)
         {
             _binaryService = new BinaryService {Proxy = proxy};
+            ChromeForTestingClient.Proxy = proxy;
             WebRequest.DefaultWebProxy = proxy;
             return this;
         }