-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for chrome for testing apis #254
Added support for chrome for testing apis #254
Conversation
Adds support for chrome driver versions greater than or equal to 115
Using .Result with private ChromeVersionInfo GetVersionFromChromeForTestingApi(string version)
{
var task = Task.Run(() => _chromeForTestingClient.GetKnownGoodVersionsWithDownloads());
task.Wait();
var knownGoodVersions = task.Result;
_chromeVersionInfo = knownGoodVersions.Versions.FirstOrDefault(cV => cV.Version == version);
return _chromeVersionInfo;
} I also made edit: I think I am running into issues with HttpClient not working with proxy correctly since it's not using the WithProxy settings |
@JDCain I've applied some of those recommended fixes, thanks for that! :) As for the WithProxy settings, I'll have to revise how this is built a little to cater for that use case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's merge it.
Thanks a lot!
Hi all, now that this PR has been merged, when does the updated package get published? Thank you! |
It has been released now! |
This PR adds support for the new Chrome for Testing API's, as a side-effect it resolves issues seen in #253 where versions of Chrome higher than or equal to 115.0.5763.0 would result in a 404 response when attempting to download the required chrome driver. I've also retained backwards compatibility with the older Chrome driver storage API's as older versions currently aren't supported by the Chrome for Testing API's.
This PR also fixes issues with downloading older versions of Chrome driver on ARM64 based machines, previously Chrome driver versions less than or equal to 106.0.5249.21 would fail to download due to the Chrome storage API's using the
64_m1
extension instead of thearm64
extension which has now been adopted since.