Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pico-w BSP #380

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

Add pico-w BSP #380

wants to merge 30 commits into from

Conversation

jannic
Copy link
Member

@jannic jannic commented Jul 9, 2022

This is very much a WIP - don't take anything for granted.

9names
9names requested changes Jul 9, 2022
View reviewed changes
boards/rp-pico-w/Cargo.toml Outdated Show resolved Hide resolved
boards/rp-pico-w/README.md Outdated Show resolved Hide resolved
boards/rp-pico-w/README.md Outdated Show resolved Hide resolved
boards/rp-pico-w/examples/pico_w_blinky.rs Outdated Show resolved Hide resolved
@DavidBChristensen
Copy link

@jannic Great start! Are you developing the WiFi Driver, or are you looking for contributors?

@9names
Copy link
Member

9names commented Jul 17, 2022

@DavidBChristensen there is already a wifi driver that is working with embassy-rp
https://github.com/embassy-rs/cyw43
It currently uses gpio bitbanging to talk to the wifi chip. We need to bring that up with rp-hal, port the PIO driver from pico-sdk, and hook that in.
If you think you can do any of those tasks, feel free to do so.

@jannic
Copy link
Member Author

jannic commented Jul 17, 2022

I definitely plan to somehow integrate the driver into the pico-w BSP, but I didn't start yet. Any help is appreciated!

@jannic jannic force-pushed the pico-w branch 4 times, most recently from 228edeb to a3279bd Compare September 5, 2022 22:03
@jannic
Copy link
Member Author

jannic commented Sep 5, 2022

The version in this branch is now able to join a wireless network. It does respond to pings!

Probably other smoltcp features work as well, I just didn't test them yet. However, it's not yet stable: Bombarding the device with IP packets quickly leads to error messages from the cyw43 driver and subsequent firmware crashes.

jannic and others added 19 commits September 17, 2022 16:03
@jannic
Initial work on a BSP for Pico W
48a3439
@jannic
Add section about rp-pico-w to README.md
e44b2fd
@jannic
Update READMEs
6a0d16c
@jannic @9names
Apply suggestions from code review
f00613b 
Co-authored-by: 9names <[email protected]>
@jannic
Implement blinky
b2dc4d2
@jannic
use released version of embassy-futures
4907194
@jannic
use net-stable
a6077b9
@jannic
Implement joining network
2f7a29b
@jannic
Mark dev-dependencies as such
27b26b8
@jannic
update embassy version
eca0788
@jannic
WIP
7f63895
@jannic
Make firmware flashing optional
389cc7d
@jannic
Uset timer::Instant
a524d33
@jannic
Avoid ill-defined > operation on Instant
034681b 
See korken89/fugit#36.

Here, we know that the underlying u64 won't overflow, so const_cmp is fine.
@jannic
Avoid ill-defined > operation on Instant
cebf1e5 
See korken89/fugit#36.

Here, we know that the underlying u64 won't overflow, so const_cmp is fine.
@jannic
Cleanups
f87f942
@jannic
Updates from main branch
5e52e86
@jannic
cargo fmt
69f68fa
@jannic
Make environment variable WIFI_NETWORK optional
ce4032c
@FireAndIceFrog
Copy link

Is this still active? What happened here?

@jannic
Copy link
Member Author

jannic commented Nov 9, 2022

It's currently on hold because I want rp-hal to work on stable rust, and some of the dependencies from embassy are still nightly-only. It might be possible to fork them and build a less ergonomic variant which works on stable. However, I don't have time to do that.
Sooner or later, either rustc will stabilize the needed features, or somebody (perhaps me) will become so impatient that a port to stable rust will be done :-)
If you want to use the pico-w with rust now, your best bet is using embassy.

@9names
Copy link
Member

9names commented Nov 11, 2022 •
edited
Loading

What do we need in the HAL to support this that requires nightly?
If it's just because they're in the same workspace (or because it will make our CI messy), can put it in a repo by itself for the time being?

@jannic
Copy link
Member Author

jannic commented Nov 17, 2022

What do we need in the HAL to support this that requires nightly? If it's just because they're in the same workspace (or because it will make our CI messy), can put it in a repo by itself for the time being?

In fact I misremembered, the nightly requirement was already solved. pico_w_blinky compiles on stable rust and works.
What's preventing a release to crates.io are some unreleased dependencies:

  • cyw43
  • embassy-net
  • embassy-executor

@carloo1
Copy link

carloo1 commented May 15, 2024 •
edited
Loading

some unreleased dependencies

Now that the embassy crates have been released, can this PR be completed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9names 9names 9names requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jannic @DavidBChristensen @9names @FireAndIceFrog @carloo1