Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs annular combusion chamber example no longer correct #184

Closed
rparini opened this issue Aug 9, 2022 · 0 comments · Fixed by #198
Closed

Docs annular combusion chamber example no longer correct #184

rparini opened this issue Aug 9, 2022 · 0 comments · Fixed by #198
Labels
bug
Milestone
v2

Comments

@rparini
Copy link
Owner

rparini commented Aug 9, 2022

Since we changed this test in #173 we would need to change the docs too. Or perhaps change the default values?

Screenshot 2022-08-09 at 02 44 55
@rparini rparini added the bug label Aug 9, 2022
@rparini rparini changed the title Docs example no longer correct Docs annular_combusion example no longer correct Aug 9, 2022
@rparini rparini changed the title Docs annular_combusion example no longer correct Docs annular combusion chamber example no longer correct Aug 9, 2022
@rparini rparini added this to the v2 milestone Aug 9, 2022
rparini added a commit that referenced this issue Aug 10, 2022
@rparini
Change integration tolerances to 1.49e-08
55dd192 
Will resolve #184
@rparini rparini mentioned this issue Aug 10, 2022
Merged
rparini added a commit that referenced this issue Aug 10, 2022
@rparini
Change integration tolerances to 1.49e-08 (#198)
79d4bba 
Will resolve #184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2
Development

Successfully merging a pull request may close this issue.

Change integration tolerances to 1.49e-08 rparini/cxroots
1 participant
@rparini