Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you sharing the detail information about online intrinsic camera calibration #169

Closed
arenas7307979 opened this issue May 30, 2021 · 4 comments · Fixed by #186
Closed
Labels
bug Something isn't working question Theory or implementation question

Comments

@arenas7307979
Copy link

arenas7307979 commented May 30, 2021

Thanks for sharing! That's an awesome work
Could you introduce the cost function, Jacobin, and optimization process for online camera intrinsic calibration?

@goldbattle goldbattle added the question Theory or implementation question label May 30, 2021
@goldbattle
Copy link
Member

@arenas7307979
Copy link
Author

Thank you for your reply.

@arenas7307979
Copy link
Author

arenas7307979 commented Jun 24, 2021

hii,
I found a difference between the document and code,
code : (2 * cam_d(4) * x_2 + 4 * cam_d(5) * x_2 * r)
document: 2 * p1 * xn^2 + 4 * k2 * xn^2 *(xn^2 + yn^2)
Should I change r to r squared

(Other parts also have this problem )

image

image

image

@goldbattle goldbattle reopened this Jun 25, 2021
@goldbattle goldbattle added the debugging Might be a bug, looking into the issue label Jun 25, 2021
@goldbattle
Copy link
Member

Thanks, documentation is correct. Will correct in an upcoming commit.

@goldbattle goldbattle added bug Something isn't working and removed debugging Might be a bug, looking into the issue labels Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Theory or implementation question
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants