-
Notifications
You must be signed in to change notification settings - Fork 165
Conversation
@@ -18,7 +18,7 @@ use thiserror::Error; | |||
#[error("no dnslink entry")] | |||
pub struct DnsLinkError; | |||
|
|||
type FutureAnswer = Pin<Box<dyn Future<Output = Result<Answer, io::Error>>>>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: this one gave me a bit of a headache - the compiler was pointing to a very long issue with the HTTP warp call, but this was actually the root cause of the problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I wonder if the future should be just written open as async fn
to be simpler in every way, but haven't tried this myself ... for a while at least. Though, there's nothing obvious causing this, perhaps the path inside domain-resolve is just so long.
seems that I've missed a test - I'll leave this one here as a draft and tinker with it some more |
Signed-off-by: ljedrz <[email protected]>
Signed-off-by: ljedrz <[email protected]>
… /dns Signed-off-by: ljedrz <[email protected]>
Signed-off-by: ljedrz <[email protected]>
the curious thing is that only the |
Signed-off-by: ljedrz <[email protected]>
Signed-off-by: ljedrz <[email protected]>
Signed-off-by: ljedrz <[email protected]>
Signed-off-by: ljedrz <[email protected]>
Signed-off-by: ljedrz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
in the end the issue was that the
the solution was to use the |
Cc #6 |
bors r- |
Canceled. |
bors r+ |
Build succeeded: |
Add a rudimentary implementation of the
/dns
and/resolve
endpoints; putting it out there already, as due to the similarity of these two endpoints I'm not 100% sure how much we want to "condense" their inner workings.This upgrades or conformance suite stats from
to