Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

case-insensitive table names and proc params #185

Merged
merged 3 commits into from
Jul 28, 2020
Merged

case-insensitive table names and proc params #185

merged 3 commits into from
Jul 28, 2020

Conversation

serii833
Copy link
Contributor

@serii833 serii833 commented Jul 8, 2020

intent of this PR is to make table names and params in procedures calls case-insensitive

@serii833
Copy link
Contributor Author

serii833 commented Jul 8, 2020

RuboCop is complaining on deprecated config options.

Error: The `Layout/IndentFirstArgument` cop has been renamed to `Layout/FirstArgumentIndentation`.
(obsolete configuration found in .rubocop.yml, please update it)
The `Layout/Tab` cop has been renamed to `Layout/IndentationStyle`.
(obsolete configuration found in .rubocop.yml, please update it)
The `Layout/TrailingBlankLines` cop has been renamed to `Layout/TrailingEmptyLines`.
(obsolete configuration found in .rubocop.yml, please update it)
The `Style/BracesAroundHashParameters` cop has been removed.
(obsolete configuration found in .rubocop.yml, please update it)

@yahonda
Copy link
Collaborator

yahonda commented Jul 14, 2020

Thank you for opening a pull request. Would you mind adding some specs (tests) to make sure this change will be supported?

@yahonda yahonda merged commit b1c41a4 into rsim:master Jul 28, 2020
@yahonda
Copy link
Collaborator

yahonda commented Jul 28, 2020

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants