This repository has been archived by the owner on Nov 30, 2024. It is now read-only.
As each file is required in RSpec::Core::Configuration, push it onto requires.
#3117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
force-pushed
the
push_requires_into_config_as_required
branch
from
69a0c8b
to
739e435
Compare
JonRowe
added a commit
that referenced
this pull request
Oct 10, 2024
…ired As each file is required in RSpec::Core::Configuration, push it onto `requires`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expose
RSpec::Core::Configuration#requiresto show the list of files configured to be required, but currently if you were to look at those files during the require process they would be empty, or partially complete based on any previous config passes, this is an attempt to make this slightly more transparent, I think recording the file as required after we have required it is the best compromise?Fixes #3116