Make puma log silence completely #2011

ta1kt0me · 2018-07-15T06:23:30Z

Puma log is shown that puma server starts. Using action_dispatch_system_test_case load hook can stop its output

Before

$ bin/rspec spec/system/tasks_spec.rb
Capybara starting Puma...
* Version 3.12.0 , codename: Llamas in Pajamas
* Min threads: 0, max threads: 4
* Listening on tcp://127.0.0.1:51998
.

Finished in 1.39 seconds (files took 0.91103 seconds to load)
1 example, 0 failures

After

$ bin/rspec spec/system/tasks_spec.rb
.

Finished in 1.22 seconds (files took 0.84185 seconds to load)
1 example, 0 failures

benoittgt · 2018-07-15T09:05:50Z

Hello @ta1kt0me

Thanks a lot for your patch. By any chance do you think you can provide a test for this?

I will look at the CI (Puma requir Ruby 2.2+ minimum now).

ta1kt0me · 2018-07-16T00:42:45Z

Thanks for your comment, I'll try it.

JonRowe · 2018-07-17T08:54:37Z

Honestly I'll be happy to merge this when green (depends on #2013)

benoittgt · 2018-07-20T12:07:53Z

CI is now green. Do you think you can rebase a re-push? I can look at this, this afternoon. 👋

ta1kt0me · 2018-07-22T06:25:44Z

@benoittgt I'm sorry for late. I have rebased it.

benoittgt · 2018-07-22T18:08:58Z

Hello

It seems your test is broken. What I did instead is:

clone the repo of Rspec 3.7.0 is showing Puma logs during spec suite #1897 (comment)
Specify your branch and other rspec ones benoittgt/puma_in_rspec_output@df6d432
Then when I run rspec I don't see anymore the puma log.

The test fails on:

$ bundle exec cucumber features/system_specs/system_specs.feature:38                                                                                      [20:08:02]
/Users/bti/code/bundle/ruby/2.5.0/gems/gherkin-2.12.2/lib/gherkin/formatter/filter_formatter.rb:105: warning: constant ::Fixnum is deprecated
Using the default profile...
..F--

(::) failed steps (::)

Exit status was 1 but expected it to be 0. Output:


Randomized with seed 7465

Widget management
  enables me to create widgets (FAILED - 1)

Failures:

  1) Widget management enables me to create widgets
     Failure/Error: raise ActionController::RoutingError, "No route matches [#{env['REQUEST_METHOD']}] #{env['PATH_INFO'].inspect}"

     ActionController::RoutingError:
       No route matches [GET] "/stylesheets/application.css"



     # /Users/bti/code/bundle/ruby/2.5.0/gems/railties-5.2.0/lib/rails/rack/logger.rb:38:in `call_app'
     # /Users/bti/code/bundle/ruby/2.5.0/gems/railties-5.2.0/lib/rails/rack/logger.rb:26:in `block in call'
     # /Users/bti/code/bundle/ruby/2.5.0/gems/railties-5.2.0/lib/rails/rack/logger.rb:26:in `call'
     # /Users/bti/code/bundle/ruby/2.5.0/gems/rack-2.0.5/lib/rack/method_override.rb:22:in `call'
     # /Users/bti/code/bundle/ruby/2.5.0/gems/rack-2.0.5/lib/rack/runtime.rb:22:in `call'
     # /Users/bti/code/bundle/ruby/2.5.0/gems/rack-2.0.5/lib/rack/sendfile.rb:111:in `call'
     # /Users/bti/code/bundle/ruby/2.5.0/gems/railties-5.2.0/lib/rails/engine.rb:524:in `call'
     # /Users/bti/code/bundle/ruby/2.5.0/gems/rack-2.0.5/lib/rack/urlmap.rb:68:in `block in call'
     # /Users/bti/code/bundle/ruby/2.5.0/gems/rack-2.0.5/lib/rack/urlmap.rb:53:in `each'
     # /Users/bti/code/bundle/ruby/2.5.0/gems/rack-2.0.5/lib/rack/urlmap.rb:53:in `call'
     # /Users/bti/code/bundle/ruby/2.5.0/gems/rack-2.0.5/lib/rack/builder.rb:153:in `call'
     # /Users/bti/code/bundle/ruby/2.5.0/gems/capybara-2.18.0/lib/capybara/server.rb:44:in `call'
     # /Users/bti/code/bundle/ruby/2.5.0/gems/puma-3.12.0/lib/puma/configuration.rb:225:in `call'
     # /Users/bti/code/bundle/ruby/2.5.0/gems/puma-3.12.0/lib/puma/server.rb:658:in `handle_request'
     # /Users/bti/code/bundle/ruby/2.5.0/gems/puma-3.12.0/lib/puma/server.rb:472:in `process_client'
     # /Users/bti/code/bundle/ruby/2.5.0/gems/puma-3.12.0/lib/puma/server.rb:332:in `block in run'
     # /Users/bti/code/bundle/ruby/2.5.0/gems/puma-3.12.0/lib/puma/thread_pool.rb:133:in `block in spawn_thread'
     # ------------------
     # --- Caused by: ---
     # Capybara::CapybaraError:
     #   Your application server raised an error - It has been raised in your test code because Capybara.raise_server_errors == true
     #   /Users/bti/code/bundle/ruby/2.5.0/gems/capybara-2.18.0/lib/capybara/session.rb:145:in `raise_server_error!'

Top 1 slowest examples (1.56 seconds, 99.8% of total time):
  Widget management enables me to create widgets
    1.56 seconds ./spec/system/widget_system_spec.rb:8

Finished in 1.56 seconds (files took 1.22 seconds to load)
1 example, 1 failure

Failed examples:

rspec ./spec/system/widget_system_spec.rb:8 # Widget management enables me to create widgets

Randomized with seed 7465


 (RSpec::Expectations::ExpectationNotMetError)
features/system_specs/system_specs.feature:59:in `Then the exit status should be 0'

Failing Scenarios:
cucumber features/system_specs/system_specs.feature:38 # Scenario: System specs driven by selenium_chrome_headless

1 scenario (1 failed)
5 steps (1 failed, 2 skipped, 2 passed)
0m5.098s

So fix is good for me. I don't know how much we invest to fix the test.

JonRowe · 2018-07-22T20:19:29Z

chromedriver isn't available on travis without installing it, if theres a driver that works built in that would work, but I can see the puma output in the output...

benoittgt · 2018-08-22T15:05:04Z

Are we accepting this patch without the test?

JonRowe · 2018-08-22T20:30:58Z

I think we need some form of integration or smoke test here really

benoittgt · 2018-08-25T14:06:28Z

@ta1kt0me do you think you have a look.

Otherwise I will look at it.

ta1kt0me · 2018-08-27T14:56:45Z

@benoittgt @JonRowe I'm sorry for replying so late and thank you for your advice. I found the way which resolves #2011 (comment) 's error, but I can not be sure it's good solution.

diff --git a/Rakefile b/Rakefile
index 6bb2e0c4..435e361f 100644
--- a/Rakefile
+++ b/Rakefile
@@ -60,7 +60,7 @@ namespace :generate do

       # Rails 4 cannot use a `rails` binstub generated by Bundler
       sh "rm -f #{bindir}/rails"
-      sh "bundle exec rails new ./tmp/example_app --no-rc --skip-javascript --skip-sprockets --skip-git --skip-test-unit --skip-listen --skip-bundle --template=example_app_generator/generate_app.rb"
+      sh "bundle exec rails new ./tmp/example_app --no-rc --skip-javascript --skip-git --skip-test-unit --skip-listen --skip-bundle --template=example_app_generator/generate_app.rb"

       in_example_app do
         sh "./travis_retry_bundle_install.sh 2>&1"

The above makes all spec in green in my local. Or if you have other better solution, it might be good.

benoittgt · 2018-08-29T07:11:53Z

I think the intent to skip sprocket was to make the app smaller.

Do you think you can add a commit with this change to check the CI?

ta1kt0me · 2018-09-04T16:00:55Z

I've added the change.

benoittgt · 2018-09-04T18:32:33Z

It seems their is an issue with the webdriver.

             Unable to find chromedriver. Please download the server from http://chromedriver.storage.googleapis.com/index.html and place it somewhere on your PATH. More info at https://github.com/SeleniumHQ/selenium/wiki/ChromeDriver.

JonRowe · 2018-09-04T18:42:46Z

As per my earlier comment:

chromedriver isn't available on travis without installing it, if theres a driver that works built in that would work, but I can see the puma output in the output...

😂

.travis.yml

benoittgt · 2018-11-09T12:48:53Z

lib/rspec/rails/example/system_example_group.rb

@@ -75,6 +75,10 @@ def app

        attr_reader :driver

+        if ::Rails.version.to_f == 5.1


Could you explain why?

The first implementation is lack of considering of compatibility. action_dispatch_system_test_case is available from Rails 5.2 . The change is needed to pass System specs driven by selenium_chrome_headless spec in Rails 5.1 .

It was literally checking the method exists, then using it, can you explain the "lack of compatibility" I'm afraid I don't understand how "not calling the method if it doesn't exist" changes anything... Also note this need to work on 5.2 and beyond, so this check seems incorrect.

benoittgt · 2018-11-09T12:49:16Z

CI seems to be better.

benoittgt

CI is breaking because of SASS on Ruby 1.9.3.

Also unanswered question https://github.com/rspec/rspec-rails/pull/2011/files#r232443748 😊

benoittgt · 2018-12-08T07:35:46Z

Rakefile

@@ -60,7 +60,7 @@ namespace :generate do

      # Rails 4 cannot use a `rails` binstub generated by Bundler
      sh "rm -f #{bindir}/rails"
-      sh "bundle exec rails new ./tmp/example_app --no-rc --skip-javascript --skip-sprockets --skip-git --skip-test-unit --skip-listen --skip-bundle --template=example_app_generator/generate_app.rb"
+      sh "bundle exec rails new ./tmp/example_app --no-rc --skip-javascript --skip-git --skip-test-unit --skip-listen --skip-bundle --template=example_app_generator/generate_app.rb"


Could you explain why you changed this?

This has a cost. It seems that sprockets adds sass gem. On Ruby 1.9.3 it adds deprecation warning and breaks the CI

Failure/Error: expect(capture_exec(custom_env, exec_script)).to eq( "#{::Rails.root}/spec/mailers/previews" ) expected: "/home/travis/build/rspec/rspec-rails/tmp/example_app/spec/mailers/previews" got: #<struct CaptureExec io="DEPRECATION WARNING:\nSass 3.5 will no longer support Ruby 1.9.3.\nPlease up...ible.\n\n/home/travis/build/rspec/rspec-rails/tmp/example_app/spec/mailers/previews", exit_status=0>

I revert this line and test on Ruby 1.9.3 without issue. I didn't test on all rails version. But maybe it doesn't need to be committed?

Yep I'd like this reverted too

pirj · 2020-01-08T21:03:34Z

@ta1kt0me Can you please rebase? CI is more stable lately.

pirj · 2020-03-13T09:11:47Z

@ta1kt0me Would you like to wrap this up before we release 4.0?

benoittgt · 2020-03-15T08:18:24Z

I can handle it if needed

pirj · 2020-03-15T12:25:14Z

This would further confirm your already quite intense comeback!

Close: #2011 (comment)

ta1kt0me force-pushed the silence_puma branch from 1a48c76 to 172a502 Compare July 22, 2018 06:23

BobbyMcWho reviewed Oct 17, 2018

View reviewed changes

.travis.yml Show resolved Hide resolved

ta1kt0me force-pushed the silence_puma branch from df9b606 to a587501 Compare November 8, 2018 17:05

benoittgt reviewed Nov 9, 2018

View reviewed changes

ta1kt0me added 2 commits November 10, 2018 14:34

Make puma log silence completely

bc80fac

Enable chrome on travisci

3ad30b8

ta1kt0me force-pushed the silence_puma branch from a587501 to 3ad30b8 Compare November 10, 2018 05:38

benoittgt requested changes Dec 8, 2018

View reviewed changes

benoittgt mentioned this pull request Mar 16, 2020

Make puma log silence completely #2289

Merged

benoittgt added a commit that referenced this pull request Mar 16, 2020

Do no stick patch to 5.1

9b697ff

Close: #2011 (comment)

benoittgt added a commit that referenced this pull request Mar 16, 2020

Add changelog for #2011

d2b58d1

benoittgt closed this in 8431e7b Mar 17, 2020

benoittgt added a commit that referenced this pull request Mar 17, 2020

Add changelog for #2011

1230a71

JonRowe pushed a commit that referenced this pull request Mar 24, 2020

Do no stick patch to 5.1

b22480c

Close: #2011 (comment)

JonRowe pushed a commit that referenced this pull request Mar 24, 2020

Add changelog for #2011

a902cfd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make puma log silence completely #2011

Make puma log silence completely #2011

ta1kt0me commented Jul 15, 2018

benoittgt commented Jul 15, 2018

ta1kt0me commented Jul 16, 2018

JonRowe commented Jul 17, 2018

benoittgt commented Jul 20, 2018 •

edited

Loading

ta1kt0me commented Jul 22, 2018

benoittgt commented Jul 22, 2018

JonRowe commented Jul 22, 2018

benoittgt commented Aug 22, 2018

JonRowe commented Aug 22, 2018

benoittgt commented Aug 25, 2018

ta1kt0me commented Aug 27, 2018

benoittgt commented Aug 29, 2018

ta1kt0me commented Sep 4, 2018

benoittgt commented Sep 4, 2018

JonRowe commented Sep 4, 2018

benoittgt Nov 9, 2018

ta1kt0me Nov 10, 2018

JonRowe Nov 10, 2018

benoittgt commented Nov 9, 2018

benoittgt left a comment

benoittgt Dec 8, 2018 •

edited

Loading

JonRowe Dec 9, 2018

pirj commented Jan 8, 2020

pirj commented Mar 13, 2020

benoittgt commented Mar 15, 2020

pirj commented Mar 15, 2020

		@@ -75,6 +75,10 @@ def app

		attr_reader :driver

		if ::Rails.version.to_f == 5.1

Make puma log silence completely #2011

Make puma log silence completely #2011

Conversation

ta1kt0me commented Jul 15, 2018

benoittgt commented Jul 15, 2018

ta1kt0me commented Jul 16, 2018

JonRowe commented Jul 17, 2018

benoittgt commented Jul 20, 2018 • edited Loading

ta1kt0me commented Jul 22, 2018

benoittgt commented Jul 22, 2018

JonRowe commented Jul 22, 2018

benoittgt commented Aug 22, 2018

JonRowe commented Aug 22, 2018

benoittgt commented Aug 25, 2018

ta1kt0me commented Aug 27, 2018

benoittgt commented Aug 29, 2018

ta1kt0me commented Sep 4, 2018

benoittgt commented Sep 4, 2018

JonRowe commented Sep 4, 2018

benoittgt Nov 9, 2018

Choose a reason for hiding this comment

ta1kt0me Nov 10, 2018

Choose a reason for hiding this comment

JonRowe Nov 10, 2018

Choose a reason for hiding this comment

benoittgt commented Nov 9, 2018

benoittgt left a comment

Choose a reason for hiding this comment

benoittgt Dec 8, 2018 • edited Loading

Choose a reason for hiding this comment

JonRowe Dec 9, 2018

Choose a reason for hiding this comment

pirj commented Jan 8, 2020

pirj commented Mar 13, 2020

benoittgt commented Mar 15, 2020

pirj commented Mar 15, 2020

benoittgt commented Jul 20, 2018 •

edited

Loading

benoittgt Dec 8, 2018 •

edited

Loading