py_get_attr(silent=TRUE): don't leave global python exception set if attr missing
#1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-kalinowski
changed the title
t-kalinowski
changed the title
py_get_attr(silent=TRUE): don't leave global python exception set if attr missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While tracking down a different bug I discovered that reticulate will not work w/ a debug build of Python. This appears to mostly be due to some locations where we silently cause the python global error status to be set in C and then don't clear the error status (e.g.,
py_get_attr_impl(,silent=TRUE)). Debug assertions in the python codebase subsequently promote the error status to a bona-fide python exception.