Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow request for editor context by id #10872

Merged
merged 1 commit into from
Apr 6, 2022
Merged

allow request for editor context by id #10872

merged 1 commit into from
Apr 6, 2022

Conversation

kevinushey
Copy link
Contributor

@kevinushey kevinushey commented Mar 30, 2022 •
edited
Loading

Intent

Addresses rstudio/rstudioapi#251. See also: rstudio/rstudioapi#253

Approach

Extend the existing getSourceEditorContext() API to allow the user to specify an explicit document ID.

Automated Tests

Not included.

QA Notes

We'll request verification from Garrick.

Checklist

  • If this PR adds a new feature, or fixes a bug in a previously released version, it includes an entry in NEWS.md
  • If this PR adds or changes UI, the updated UI meets accessibility standards
  • A reviewer is assigned to this PR (if unsure who to assign, check Area Owners list)
  • This PR passes all local unit tests

@kevinushey kevinushey requested a review from jgutman March 30, 2022 22:36
@kevinushey kevinushey mentioned this pull request Mar 30, 2022
Merged
@kevinushey kevinushey merged commit ec781aa into main Apr 6, 2022
@kevinushey kevinushey deleted the feature/api-document-context branch April 6, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgutman jgutman jgutman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinushey @jgutman