Add functionality to also return the actual selected LatLng from Goog… #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtchagas
requested changes
Mar 5, 2020
| @@ -97,6 +105,7 @@ class PingPlacePicker private constructor() { | |||
| companion object { | |||
|
|
|||
| const val EXTRA_PLACE = "extra_place" | |||
| const val ACTUAL_SELECTED_LATLNG = "actual_selected_latlng" | |||
There was a problem hiding this comment.
Please follow the naming standards for extras.
Would be nice: EXTRA_ACTUAL_LATLNG = "extra_actual_latlng"
| @@ -62,6 +62,7 @@ class PlacePickerActivity : AppCompatActivity(), PingKoinComponent, | |||
|
|
|||
| // For passing extra parameters to this activity. | |||
| const val EXTRA_LOCATION = "extra_location" | |||
| const val IS_SHOULD_RETURN_ACTUAL_LATLNG = "is_should_return_actual_latlng" | |||
There was a problem hiding this comment.
Same here: EXTRA_SHOULD_RETURN_ACTUAL_LATLNG
|
@rtchagas variable updated according to naming standards |
|
@rtchagas and thank you for releasing this immediately 😃 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request proposal for issue #62
It would be really cool if you could take a look at this this week, since this functionality is quite urgent for me 😅