Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in Rails/FindEach #408

Merged
merged 1 commit into from
Dec 12, 2020
Merged

Fix bug in Rails/FindEach #408

merged 1 commit into from
Dec 12, 2020

Conversation

ghiculescu
Copy link
Contributor

@ghiculescu ghiculescu commented Dec 11, 2020

Fixes a bug in #392

It never worked, because it was comparing strings (from config) to symbols (from method_name). The tests only passed because of what was in SCOPE_METHODS.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic koic merged commit abbb4fa into rubocop:master Dec 12, 2020
@koic
Copy link
Member

koic commented Dec 12, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants