Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #389] Add IgnoredMethods configuration option for Rails/FindEach cop #392

Merged
merged 1 commit into from
Nov 26, 2020

Conversation

tejasbubane
Copy link
Contributor

Closes #389

Also add lock to IgnoredMethods.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

config/default.yml Outdated Show resolved Hide resolved
config/default.yml Outdated Show resolved Hide resolved
@koic
Copy link
Member

koic commented Nov 26, 2020

Thanks!

@artplan1
Copy link

Thank you

@tejasbubane tejasbubane deleted the fix-389 branch November 26, 2020 16:06
@ghiculescu ghiculescu mentioned this pull request Dec 11, 2020
9 tasks
@ghiculescu
Copy link
Contributor

FYI #408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/FindEach should ignore queries with lock
4 participants