Added duplicated tests run hint. #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
requested changes
Apr 17, 2022
koic
reviewed
Apr 17, 2022
README.adoc
Outdated
|
|
||
| [source,ruby] | ||
| ---- | ||
| # example |
There was a problem hiding this comment.
Can you update it?
Suggested change
| # example | |
| # bad |
There was a problem hiding this comment.
Maybe
# bad (unless multiple runs are the intended behavior)
There was a problem hiding this comment.
(I find the good/bad terminology that the guides use to be not ideal, since they don't really account for nuance or context).
andyw8
reviewed
Apr 17, 2022
ignacio-chiazzo
force-pushed
the
added-duplicated-tests
branch
2 times, most recently
from
c0542fe to
b40401e
Compare
|
Thanks. Can you squash your commits into one? |
Minitest uses Ruby classes, if a Minitest class inherits from another class, it will also inherit its methods causing Minitest to run the parent's tests twice. In some cases, we want them to run them twice, but most of the time, we don't. This commit contains an informative example This blog post contains more info: https://ignaciochiazzo.medium.com/dont-run-your-ruby-minitest-classes-twice-988645662cdb.
ignacio-chiazzo
force-pushed
the
added-duplicated-tests
branch
from
b40401e to
df12a46
Compare
andyw8
approved these changes
Apr 17, 2022
|
👍 |
koic
added a commit
to rubocop/rubocop-minitest
that referenced
this pull request
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minitest uses Ruby classes, if a Minitest class inherits from another class, it will also inherit its methods causing Minitest to run the parent's tests twice. In some cases, we want them to run them twice, but most of the time, we don't.
This warning is based on a Rubocop rule for duplicated tests. This blog post and this library contain more information.
Fixes #45