Add "Prefer to_fs" rule
#314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Apr 19, 2022
Follow up rubocop/rails-style-guide#314. This cop checks for consistent uses of `to_fs` or `to_formatted_s`, depending on the cop's configuration. ## EnforcedStyle: to_fs (default) ```ruby # bad time.to_formatted_s(:db) # good time.to_fs(:db) ``` ## EnforcedStyle: to_formatted_s ``` # bad time.to_fs(:db) # good time.to_formatted_s(:db) ```
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Apr 19, 2022
Follow up rubocop/rails-style-guide#314. This cop checks for consistent uses of `to_fs` or `to_formatted_s`, depending on the cop's configuration. ## EnforcedStyle: to_fs (default) ```ruby # bad time.to_formatted_s(:db) # good time.to_fs(:db) ``` ## EnforcedStyle: to_formatted_s ``` # bad time.to_fs(:db) # good time.to_formatted_s(:db) ```
10 tasks
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Apr 19, 2022
Follow up rubocop/rails-style-guide#314. This cop checks for consistent uses of `to_fs` or `to_formatted_s`, depending on the cop's configuration. ## EnforcedStyle: to_fs (default) ```ruby # bad time.to_formatted_s(:db) # good time.to_fs(:db) ``` ## EnforcedStyle: to_formatted_s ``` # bad time.to_fs(:db) # good time.to_formatted_s(:db) ```
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Apr 19, 2022
Follow up rubocop/rails-style-guide#314. This cop checks for consistent uses of `to_fs` or `to_formatted_s`, depending on the cop's configuration. ## EnforcedStyle: to_fs (default) ```ruby # bad time.to_formatted_s(:db) # good time.to_fs(:db) ``` ## EnforcedStyle: to_formatted_s ``` # bad time.to_fs(:db) # good time.to_formatted_s(:db) ```
andyw8
reviewed
Apr 19, 2022
README.adoc
Outdated
| @@ -1575,6 +1575,25 @@ hash.exclude?(:key) | |||
| string.exclude?('substring') | |||
| ---- | |||
|
|
|||
| === Prefer `to_fs` [[prefer-to-fs]] | |||
There was a problem hiding this comment.
To give the header a bit more context, how about:
Suggested change
| === Prefer `to_fs` [[prefer-to-fs]] | |
| === Prefer `to_fs` for Formatted Strings[[prefer-to-fs]] |
andyw8
reviewed
Apr 19, 2022
README.adoc
Outdated
| @@ -1575,6 +1575,25 @@ hash.exclude?(:key) | |||
| string.exclude?('substring') | |||
| ---- | |||
|
|
|||
| === Prefer `to_fs` [[prefer-to-fs]] | |||
There was a problem hiding this comment.
To give the header a bit more context, how about:
Suggested change
| === Prefer `to_fs` [[prefer-to-fs]] | |
| === Prefer `to_fs` for Formatted Strings[[prefer-to-fs]] |
andyw8
approved these changes
Apr 19, 2022
Follow up rails/rails#44354. Also, the deprecated warning for `to_s(:db)` is `to_fs(:db)` instead of `to_formatted_s(:db)`. > DateTime#to_s(:db) is deprecated. Please use DateTime#to_fs(:db) instead.
koic
force-pushed
the
add_to_formatted_s_rule
branch
from
4af97d7
to
2750e9d
Compare
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Apr 20, 2022
Follow up rubocop/rails-style-guide#314. This cop checks for consistent uses of `to_fs` or `to_formatted_s`, depending on the cop's configuration. ## EnforcedStyle: to_fs (default) ```ruby # bad time.to_formatted_s(:db) # good time.to_fs(:db) ``` ## EnforcedStyle: to_formatted_s ``` # bad time.to_fs(:db) # good time.to_formatted_s(:db) ```
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Apr 20, 2022
Follow up rubocop/rails-style-guide#314. This cop checks for consistent uses of `to_fs` or `to_formatted_s`, depending on the cop's configuration. ## EnforcedStyle: to_fs (default) ```ruby # bad time.to_formatted_s(:db) # good time.to_fs(:db) ``` ## EnforcedStyle: to_formatted_s ``` # bad time.to_fs(:db) # good time.to_formatted_s(:db) ```
andyw8
approved these changes
Apr 20, 2022
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Apr 21, 2022
Follow up rubocop/rails-style-guide#314. This cop checks for consistent uses of `to_fs` or `to_formatted_s`, depending on the cop's configuration. ## EnforcedStyle: to_fs (default) ```ruby # bad time.to_formatted_s(:db) # good time.to_fs(:db) ``` ## EnforcedStyle: to_formatted_s ``` # bad time.to_fs(:db) # good time.to_formatted_s(:db) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up rails/rails#44354.
Also, the deprecated warning for
to_s(:db)isto_fs(:db)instead ofto_formatted_s(:db).