Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a build error #278

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Fix a build error #278

merged 1 commit into from
Feb 24, 2024

Conversation

koic
Copy link
Member

@koic koic commented Feb 24, 2024

This PR fixes the following build error when using Ruby 3.4dev:

$ ruby -v
ruby 3.4.0dev (2024-02-24T04:19:37Z master e9e752c7ef) [x86_64-darwin23]
$ bundle exec rspec ./spec/rubocop/ast/node_spec.rb:322
Run options: include {:locations=>{"./spec/rubocop/ast/node_spec.rb"=>[322]}}

Randomized with seed 21659
F

Failures:

  1) RuboCop::AST::Node#pure? for a regexp with no interpolation returns true
     Failure/Error: let(:src) { URI::DEFAULT_PARSER.make_regexp.inspect }

     NameError:
       uninitialized constant URI
     # ./spec/rubocop/ast/node_spec.rb:320:in 'block (5 levels) in <top (required)>'
     # ./spec/rubocop/ast/node_spec.rb:4:in 'block (2 levels) in <top (required)>'
     # ./spec/rubocop/ast/node_spec.rb:5:in 'block (2 levels) in <top (required)>'
     # ./spec/rubocop/ast/node_spec.rb:323:in 'block (5 levels) in <top (required)>'

Finished in 0.00259 seconds (files took 0.32884 seconds to load)
1 example, 1 failure

Failed examples:

rspec ./spec/rubocop/ast/node_spec.rb:322 # RuboCop::AST::Node#pure? for a regexp with no interpolation returns true

This PR fixes the following build error when using Ruby 3.4dev:

```console
$ ruby -v
ruby 3.4.0dev (2024-02-24T04:19:37Z master e9e752c7ef) [x86_64-darwin23]
$ bundle exec rspec ./spec/rubocop/ast/node_spec.rb:322
Run options: include {:locations=>{"./spec/rubocop/ast/node_spec.rb"=>[322]}}

Randomized with seed 21659
F

Failures:

  1) RuboCop::AST::Node#pure? for a regexp with no interpolation returns true
     Failure/Error: let(:src) { URI::DEFAULT_PARSER.make_regexp.inspect }

     NameError:
       uninitialized constant URI
     # ./spec/rubocop/ast/node_spec.rb:320:in 'block (5 levels) in <top (required)>'
     # ./spec/rubocop/ast/node_spec.rb:4:in 'block (2 levels) in <top (required)>'
     # ./spec/rubocop/ast/node_spec.rb:5:in 'block (2 levels) in <top (required)>'
     # ./spec/rubocop/ast/node_spec.rb:323:in 'block (5 levels) in <top (required)>'

Finished in 0.00259 seconds (files took 0.32884 seconds to load)
1 example, 1 failure

Failed examples:

rspec ./spec/rubocop/ast/node_spec.rb:322 # RuboCop::AST::Node#pure? for a regexp with no interpolation returns true
```
@koic koic merged commit 38e4648 into rubocop:master Feb 24, 2024
19 of 20 checks passed
@koic koic deleted the fix_build_error branch February 24, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant