-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add job for CI using Prism parser #112
Conversation
1075b45
to
1719fc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I’d feel a tad more confident if we ran rake default, not just the spec task
OK. I updated this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
If there is a problem, we can delete this job so I merge this PR. |
Copied from rubocop/rubocop-capybara#112 Co-authored-by: ydah <[email protected]>
Copied from rubocop/rubocop-capybara#112 Co-authored-by: ydah <[email protected]>
Copied from rubocop/rubocop-capybara#112 Co-authored-by: ydah <[email protected]>
Copied from rubocop/rubocop-capybara#112 Co-authored-by: ydah <[email protected]>
Follow up rubocop/rubocop-ast#277
Before submitting the PR make sure the following are checked:
main
(if not - rebase it).CHANGELOG.md
if the new code introduces user-observable changes.bundle exec rake
) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).