Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job for CI using Prism parser #112

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Add job for CI using Prism parser #112

merged 1 commit into from
Mar 24, 2024

Conversation

ydah
Copy link
Member

@ydah ydah commented Mar 21, 2024

Follow up rubocop/rubocop-ast#277


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with main (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@ydah ydah requested a review from a team as a code owner March 21, 2024 09:35
Rakefile Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
@ydah ydah requested a review from pirj March 21, 2024 11:17
@ydah ydah force-pushed the support_prism branch 3 times, most recently from 1075b45 to 1719fc6 Compare March 21, 2024 14:11
@ydah ydah changed the title Support Prism as a Ruby parser Add job for CI using Prism parser Mar 21, 2024
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I’d feel a tad more confident if we ran rake default, not just the spec task

@ydah
Copy link
Member Author

ydah commented Mar 22, 2024

I’d feel a tad more confident if we ran rake default, not just the spec task

OK. I updated this PR.

Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ydah
Copy link
Member Author

ydah commented Mar 24, 2024

If there is a problem, we can delete this job so I merge this PR.

@ydah ydah merged commit b83899a into main Mar 24, 2024
26 checks passed
@ydah ydah deleted the support_prism branch March 24, 2024 15:19
bquorning added a commit to rubocop/rubocop-rspec that referenced this pull request Oct 17, 2024
bquorning added a commit to rubocop/rubocop-rspec that referenced this pull request Oct 17, 2024
bquorning added a commit to rubocop/rubocop-rspec that referenced this pull request Oct 29, 2024
bquorning added a commit to rubocop/rubocop-rspec that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants