Enforce assert_operator instead of assert with operator expression #255
Labels
feature request
Request for new functionality
Comments
|
👍 Sounds like a useful cop to add. |
koic
added a commit
to koic/rubocop-minitest
that referenced
this issue
Sep 21, 2023
…uteOperator` cops Fixes rubocop#255. This PR adds new `Minitest/AssertOperator` and `Minitest/RefuteOperator` cops. ## `Minitest/AssertOperator` cop This cop enforces the use of `assert_operator(expected, :<, actual)` over `assert(expected < actual)`. ```ruby # bad assert(expected < actual) # good assert_operator(expected, :<, actual) ``` ## `Minitest/RefuteOperator` cop This cop enforces the use of `refute_operator(expected, :<, actual)` over `refute(expected < actual)`. ```ruby # bad refute(expected < actual) # good refute_operator(expected, :<, actual) ```
8 tasks
koic
added a commit
that referenced
this issue
Sep 22, 2023
…d_refute_operator_cops [Fix #255] Add new `Minitest/AssertOperator` and `Minitest/RefuteOperator` cops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
When reviewing PRs of teammates using for example
assert(a < b)Describe the solution you'd like
I'd like rubocop to recommend for example
assert_operator(a, :<, b)Additional context
I was surprised I couldn't find this cop, as it seems pretty simple to implement (possibly naively) and it's in the minitest style guide https://github.com/rubocop/minitest-style-guide#assert-operator
Would you accept a PR for a new cop
Minitest/AssertOperator?Thanks
The text was updated successfully, but these errors were encountered: