Make Minitest/UnreachableAssertion aware of assert and refute prefix methods
#158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refix methods This PR makes `Minitest/UnreachableAssertion` aware of `assert` and `refute` prefix methods and removes `MinitestExplorationHelpers#assertion?` method. It makes the detection to assertion methods consistent. NOTE: The `MinitestExplorationHelpers#assertion?` method is redundant with `MinitestExplorationHelpers#assertion_method?` OTOH, the implementation uses `MinitestExplorationHelpers#assertion` instead of `MinitestExplorationHelpers#assertion_method?`. Maybe it's enough to verify that it starts with `assert` or `refute` instead of exact match of the known assertion method names.
koic
force-pushed
the
make_minitest_unreachable_assertion_aware_of_assertion_prefix_method
branch
from
4d5a02f
to
bfdadd2
Compare
koic
deleted the
make_minitest_unreachable_assertion_aware_of_assertion_prefix_method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
Minitest/UnreachableAssertionaware ofassertandrefuteprefix methods and removesMinitestExplorationHelpers#assertion?method. It makes the detection to assertion methods consistent.NOTE: The
MinitestExplorationHelpers#assertion?method is redundant withMinitestExplorationHelpers#assertion_method?OTOH, the implementation usesMinitestExplorationHelpers#assertioninstead ofMinitestExplorationHelpers#assertion_method?. Maybe it's enough to verify that it starts withassertorrefuteinstead of exact match of the known assertion method names.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.