-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AssertKindOf
: also replace is_a?
as well
#298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amomchilov
force-pushed
the
AssertKindOf-is_a
branch
from
January 10, 2024 21:35
defcc5b
to
50baa74
Compare
amomchilov
changed the title
AssertKindOf: also replace
Jan 10, 2024
is_a?
as wellAssertKindOf
: also replace is_a?
as well
amomchilov
force-pushed
the
AssertKindOf-is_a
branch
from
January 10, 2024 22:07
50baa74
to
6b91ee1
Compare
|
amomchilov
force-pushed
the
AssertKindOf-is_a
branch
from
January 11, 2024 01:21
6069c01
to
b0677a1
Compare
koic
reviewed
Jan 11, 2024
koic
reviewed
Jan 11, 2024
koic
reviewed
Jan 11, 2024
koic
reviewed
Jan 11, 2024
koic
reviewed
Jan 11, 2024
amomchilov
force-pushed
the
AssertKindOf-is_a
branch
2 times, most recently
from
January 11, 2024 03:49
2e86910
to
6a92336
Compare
koic
reviewed
Jan 11, 2024
koic
reviewed
Jan 11, 2024
I've left two comments. Can you update these and squash this PR's commits into one? |
... likewise for RefuteKindOf.
amomchilov
force-pushed
the
AssertKindOf-is_a
branch
from
January 11, 2024 17:20
6a92336
to
8627375
Compare
@koic Fixed and squashed! Thanks for reviewing |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Minitest/AssertKindOf
would replace this code:... but not:
...even though they are practically the same, since
#is_a?
is an alias for#kind_of?
(not to be confused with#instance_of?
).This PR simply extends
Minitest/AssertKindOf
to correct both.I opted to modify the existing cop, rather than introducing a new cop like
Minitest/AssertIsA
, because it seems really unlikely to me that somebody would like to correct one, but not the other. Perhaps that's just a lack of imagination, let me know if there are any objections.Before submitting the PR make sure the following are checked:
Commit message starts with[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.