[Fix #301] Add new Minitest/Focus cop

changelog/new_add_new_minitest_no_focus_cop.md

@@ -0,0 +1 @@
+* [#301](https://github.com/rubocop/rubocop-minitest/issues/301): Add new Minitest/Focus cop. ([@jaredmoody][])

config/default.yml

@@ -146,6 +146,11 @@ Minitest/EmptyLineBeforeAssertionMethods:
   Enabled: pending
   VersionAdded: '0.23'
 
+Minitest/Focus:
+  Description: 'Checks for focused tests.'
+  Enabled: pending
+  VersionAdded: '<<next>>'
+
 Minitest/GlobalExpectations:
   Description: 'This cop checks for deprecated global expectations.'
   StyleGuide: 'https://minitest.rubystyle.guide#global-expectations'

lib/rubocop/cop/minitest/focus.rb

@@ -0,0 +1,49 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Minitest
+      # Enforces tests are not focused.
+      #
+      # @example
+      #   # bad
+      #   focus test 'foo' do
+      #   end
+      #
+      #   # bad
+      #   focus
+      #   test 'foo' do
+      #   end
+      #
+      #   # good
+      #   test 'foo' do
+      #   end
+      #
+      class Focus < Base
+        extend AutoCorrector
+        include RangeHelp
+
+        MSG = 'Remove `focus` from tests.'
+        RESTRICT_ON_SEND = [:focus].freeze
+
+        def_node_matcher :focused?, <<~PATTERN
+          (send nil? :focus ...)
+        PATTERN
+
+        def on_send(node)
+          return if node.receiver
+
+          add_offense(node.loc.selector) do |corrector|
+            range = if node.arguments.none?
+                      range_by_whole_lines(node.source_range, include_final_newline: true)
+                    else
+                      node.loc.selector.join(node.first_argument.source_range.begin)
+                    end
+
+            corrector.remove(range)
+          end
+        end
+      end
+    end
+  end
+end

lib/rubocop/cop/minitest_cops.rb

@@ -30,6 +30,7 @@
 require_relative 'minitest/assert_truthy'
 require_relative 'minitest/duplicate_test_run'
 require_relative 'minitest/empty_line_before_assertion_methods'
+require_relative 'minitest/focus'
 require_relative 'minitest/non_executable_test_method'
 require_relative 'minitest/redundant_message_argument'
 require_relative 'minitest/return_in_test_method'

test/rubocop/cop/minitest/focus_test.rb

@@ -0,0 +1,49 @@
+# frozen_string_literal: true
+
+require_relative '../../../test_helper'
+
+class FocusTest < Minitest::Test
+  def test_registers_offense_when_using_direct_focus
+    assert_offense(<<~RUBY)
+      class FooTest < Minitest::Test
+        focus test 'foo' do
+        ^^^^^ Remove `focus` from tests.
+        end
+      end
+    RUBY
+
+    assert_correction(<<~RUBY)
+      class FooTest < Minitest::Test
+        test 'foo' do
+        end
+      end
+    RUBY
+  end
+
+  def test_registers_offense_when_using_indirect_focus
+    assert_offense(<<~RUBY)
+      class FooTest < Minitest::Test
+        focus
+        ^^^^^ Remove `focus` from tests.
+        test 'foo' do
+        end
+      end
+    RUBY
+
+    assert_correction(<<~RUBY)
+      class FooTest < Minitest::Test
+        test 'foo' do
+        end
+      end
+    RUBY
+  end
+
+  def test_does_not_register_offense_when_no_focus
+    assert_no_offenses(<<~RUBY)
+      class FooTest < Minitest::Test
+        test 'foo' do
+        end
+      end
+    RUBY
+  end
+end