Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace EnsureNode.body with EnsureNode.branch #324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dvandersluis
Copy link
Member

EnsureNode.body has been deprecated in rubocop/rubocop-ast#337, and will be reimplemented in the next major version of rubocop-ast. In order to prepare for that, existing EnsureNode.body calls, which retreive the ensure branch of exception handling, have been replaced with EnsureNode.branch.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@dvandersluis dvandersluis changed the title Replace EnsureNode.body with EnsureNode.branch. Replace EnsureNode.body with EnsureNode.branch Nov 13, 2024
@dvandersluis
Copy link
Member Author

dvandersluis commented Nov 13, 2024

There appears to be an unrelated test failure:

  1) Failure:
MultipleAssertionsTest#test_all_types_of_assignments_are_understood [test/rubocop/cop/minitest/multiple_assertions_test.rb:131]:
--- expected
+++ actual
@@ -1,6 +1,6 @@
 "class FooTest < Minitest::Test
   def test_all_types_of_assignment
-  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Test case has too many assertions [8/1].
+  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Test case has too many assertions [9/1].
     # lvasgn
     foo = assert_equal(1, 1)
     # ivasgn

I opened #325 to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant