Merge pull request #210 from koic/fix_false_negative_for_performance_…

…bind_call

Fix a false negative for `Performance/BindCall`

CHANGELOG.md

@@ -9,6 +9,7 @@
 ### Bug fixes
 
 * [#207](https://github.com/rubocop-hq/rubocop-performance/issues/207): Fix an error for `Performance/Sum` when using `map(&do_something).sum` without receiver. ([@koic][])
+* [#210](https://github.com/rubocop-hq/rubocop-performance/pull/210): Fix a false negative for `Performance/BindCall` when receiver is not a method call. ([@koic][])
 
 ### Changes
 

lib/rubocop/cop/performance/bind_call.rb

@@ -33,7 +33,7 @@ class BindCall < Base
         def_node_matcher :bind_with_call_method?, <<~PATTERN
           (send
             $(send
-              (send nil? _) :bind
+              _ :bind
               $(...)) :call
             $...)
         PATTERN
@@ -64,7 +64,7 @@ def message(bind_arg, call_args)
 
         def correction_range(receiver, node)
           location_of_bind = receiver.loc.selector.begin_pos
-          location_of_call = node.loc.end.end_pos
+          location_of_call = node.source_range.end.end_pos
 
           range_between(location_of_bind, location_of_call)
         end

spec/rubocop/cop/performance/bind_call_spec.rb

@@ -25,6 +25,28 @@
       RUBY
     end
 
+    it 'registers an offense when using `Foo.do_something.bind(obj).call`' do
+      expect_offense(<<~RUBY)
+        Foo.do_something.bind(obj).call
+                         ^^^^^^^^^^^^^^ Use `bind_call(obj)` instead of `bind(obj).call()`.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        Foo.do_something.bind_call(obj)
+      RUBY
+    end
+
+    it 'registers an offense when using `CONSTANT.bind(obj).call`' do
+      expect_offense(<<~RUBY)
+        CONSTANT.bind(obj).call
+                 ^^^^^^^^^^^^^^ Use `bind_call(obj)` instead of `bind(obj).call()`.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        CONSTANT.bind_call(obj)
+      RUBY
+    end
+
     it 'registers an offense when using `bind(obj).()`' do
       expect_offense(<<~RUBY)
         umethod.bind(obj).()