Skip to content

Commit

Permalink
Cut 1.20.2
Browse files Browse the repository at this point in the history
  • Loading branch information
koic committed Jan 8, 2024
1 parent 2e13b10 commit ad65d4e
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 4 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@

## master (unreleased)

## 1.20.2 (2024-01-08)

### Bug fixes

* [#425](https://github.com/rubocop/rubocop-performance/issues/425): Fix a false positive for `Performance/StringIdentifierArgument` when using string interpolation with methods that don't support symbols with `::` inside them. ([@earlopain][])
Expand Down
2 changes: 1 addition & 1 deletion docs/antora.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ name: rubocop-performance
title: RuboCop Performance
# We always provide version without patch here (e.g. 1.1),
# as patch versions should not appear in the docs.
version: ~
version: '1.20'
nav:
- modules/ROOT/nav.adoc
9 changes: 7 additions & 2 deletions docs/modules/ROOT/pages/cops_performance.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -2080,13 +2080,18 @@ and the following examples are parts of it.
send('do_something')
attr_accessor 'do_something'
instance_variable_get('@ivar')
const_get("string_#{interpolation}")
respond_to?("string_#{interpolation}")
# good
send(:do_something)
attr_accessor :do_something
instance_variable_get(:@ivar)
const_get(:"string_#{interpolation}")
respond_to?(:"string_#{interpolation}")
# good - these methods don't support namespaced symbols
const_get("#{module_path}::Base")
const_source_location("#{module_path}::Base")
const_defined?("#{module_path}::Base")
----
== Performance/StringInclude
Expand Down
2 changes: 1 addition & 1 deletion lib/rubocop/performance/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module RuboCop
module Performance
# This module holds the RuboCop Performance version information.
module Version
STRING = '1.20.1'
STRING = '1.20.2'

def self.document_version
STRING.match('\d+\.\d+').to_s
Expand Down
5 changes: 5 additions & 0 deletions relnotes/v1.20.2.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
### Bug fixes

* [#425](https://github.com/rubocop/rubocop-performance/issues/425): Fix a false positive for `Performance/StringIdentifierArgument` when using string interpolation with methods that don't support symbols with `::` inside them. ([@earlopain][])

[@earlopain]: https://github.com/earlopain

0 comments on commit ad65d4e

Please sign in to comment.