-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RedundantStringChars auto-correct #249
Labels
bug
Something isn't working
Comments
koic
added a commit
to koic/rubocop-performance
that referenced
this issue
May 21, 2021
…ngChars` Fixes rubocop#249. This PR fixes a false positive for `Performance/RedundantStringChars` when using `str.chars.last` and `str.chars.drop`.
8 tasks
tejasbubane
added a commit
to tejasbubane/rubocop-performance
that referenced
this issue
May 21, 2021
8 tasks
koic
added a commit
to koic/rubocop-performance
that referenced
this issue
May 22, 2021
…ngChars` Fixes rubocop#249. This PR fixes a false positive for `Performance/RedundantStringChars` when using `str.chars.last` and `str.chars.drop`.
koic
added a commit
that referenced
this issue
May 23, 2021
…ring_chars [Fix #249] Fix a false positive for `Performance/RedundantStringChars`
I experienced rubocop-performance 1.11.5 (held back by standardrb) |
koic
added a commit
to koic/rubocop-performance
that referenced
this issue
Nov 18, 2021
Follow up to rubocop#249 (comment). This PR fixes an incorrect autocorrect for `Performance/RedundantStringChars` when using `str.chars[0]`.
8 tasks
koic
added a commit
to koic/rubocop-performance
that referenced
this issue
Nov 18, 2021
Follow up to rubocop#249 (comment). This PR fixes an incorrect autocorrect for `Performance/RedundantStringChars` when using `str.chars[0]`.
patrickm53
pushed a commit
to patrickm53/performance-develop-rubyonrails
that referenced
this issue
Sep 23, 2022
Follow up to rubocop/rubocop-performance#249 (comment). This PR fixes an incorrect autocorrect for `Performance/RedundantStringChars` when using `str.chars[0]`.
richardstewart0213
added a commit
to richardstewart0213/performance-build-Performance-optimization-analysis-
that referenced
this issue
Nov 4, 2022
Follow up to rubocop/rubocop-performance#249 (comment). This PR fixes an incorrect autocorrect for `Performance/RedundantStringChars` when using `str.chars[0]`.
koic
added a commit
to koic/rubocop-performance
that referenced
this issue
Nov 21, 2022
…ngChars` Fixes rubocop#313. This PR fixes a false negative for `Performance/RedundantStringChars` when using `str.chars.last` without argument. Report rubocop#249 has `str.chars.last(2)` argument. rubocop#250 mistakenly changed even without arguments `str.chars.last`.
8 tasks
Cute0110
added a commit
to Cute0110/Rubocop-Performance
that referenced
this issue
Sep 28, 2023
Follow up to rubocop/rubocop-performance#249 (comment). This PR fixes an incorrect autocorrect for `Performance/RedundantStringChars` when using `str.chars[0]`.
SerhiiMisiura
added a commit
to SerhiiMisiura/Rubocop-Performance
that referenced
this issue
Oct 5, 2023
Follow up to rubocop/rubocop-performance#249 (comment). This PR fixes an incorrect autocorrect for `Performance/RedundantStringChars` when using `str.chars[0]`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
Do not set this cop as auto-correctable as it can cause breakage
Actual behavior
Auto-correct transforms into potentially broken code
Steps to reproduce the problem
NA
RuboCop version
The text was updated successfully, but these errors were encountered: