Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #230] Fix a false positive for Performance/ChainArrayAllocation #233

Conversation

koic
Copy link
Member

@koic koic commented Apr 14, 2021

Fixes #230.

This PR fixes a false positive for Performance/ChainArrayAllocation when using Enumerable#lazy.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

…ocation`

Fixes rubocop#230.

This PR fixes a false positive for `Performance/ChainArrayAllocation`
when using `Enumerable#lazy`.
@koic koic merged commit af9f527 into rubocop:master Apr 16, 2021
@koic koic deleted the fix_false_positive_for_performance_chain_array_allocation branch April 16, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lazy not accounted for in ChainArrayAllocation cop
1 participant