Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Safety section to documentation #262

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

koic
Copy link
Member

@koic koic commented Oct 10, 2021

Follow up to rubocop/rubocop#10094.

This PR adds safety section to documentation for all cops that are Safe: false or SafeAutoCorrect: false.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic koic force-pushed the add_safety_section_to_docs branch 3 times, most recently from 2794389 to 9dffed9 Compare October 11, 2021 15:39
@koic koic changed the title Add Safety section to documentation Add Safety section to documentation Oct 11, 2021
Follow up to rubocop/rubocop#10094.

This PR adds safety section to documentation for all cops that are `Safe: false` or `SafeAutoCorrect: false`.
@koic koic force-pushed the add_safety_section_to_docs branch from 9dffed9 to 868b361 Compare October 11, 2021 16:31
@koic koic merged commit e227e1c into rubocop:master Oct 22, 2021
@koic koic deleted the add_safety_section_to_docs branch October 22, 2021 22:16
koic added a commit that referenced this pull request Dec 9, 2021
patrickm53 pushed a commit to patrickm53/performance-develop-rubyonrails that referenced this pull request Sep 23, 2022
richardstewart0213 added a commit to richardstewart0213/performance-build-Performance-optimization-analysis- that referenced this pull request Nov 4, 2022
Cute0110 added a commit to Cute0110/Rubocop-Performance that referenced this pull request Sep 28, 2023
SerhiiMisiura added a commit to SerhiiMisiura/Rubocop-Performance that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant