Support autocorrection on Performance/RedundantMatch when receiver is a Regexp literal

[r7kamura]

I found the following pattern is treated as an offense but not autocorrected, so tried to support it.

# bad
something if /regexp/.match(string)

# good
something if /regexp/ =~ string

---

Before submitting the PR make sure the following are checked:

• The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
• Wrote good commit messages.
• Commit message starts with [Fix #issue-number] (if the related issue exists).
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
• Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

[koic]

Can you leave the comment to node.first_argument.regexp_type??

[r7kamura]

Roger.
Actually, I don't fully understand why this comment is necessary here. Why does this comment mention the second argument? String#match may also take a second argument, so does it need a similar comment?

[koic]

It just keeps the status quo for future maintenance. No text updates would be needed.

[koic]

In fact, this type comment is unneeded :-)

Suggested change

	# @param [RuboCop::AST::SendNode] node
	# @return [Boolean]

[koic]

Suggested change

	it 'autocorrects Regexp#match to Regexp#=~' do
	it 'registers an offense when receiver is a Regexp literal' do

[r7kamura]

I think it's a good to change about minor wording, but doesn't this completely lose the nuance of autocorrect support?
Or should we prefer that the message be ignorant as to whether autocorrect is supported or not?

[koic]

it 'registers an offense and corrects when receiver is a Regexp literal' do, WDYT?

[r7kamura]

It sounds good and much clear 👍

[koic]

nits:

Suggested change

	expect_offense(<<~TEXT)
	something if /regex/.match(str)
	^^^^^^^^^^^^^^^^^^ Use `=~` in places where the `MatchData` returned by `#match` will not be used.
	TEXT
	expect_offense(<<~RUBY)
	something if /regex/.match(str)
	^^^^^^^^^^^^^^^^^^ Use `=~` in places where the `MatchData` returned by `#match` will not be used.
	RUBY

[r7kamura]

I'm wondering if it's not a good idea to describe something that is not Ruby code as being "RUBY".

Modern editors (e.g. Visual Studio Code) recognize this heredoc delimiter as a language name and do syntax highlighting, but this heredoc includes ^^^... , which is clearly not Ruby code and therefore it fails to parse

then syntax highlighting for the rest of code will be broken.

[koic]

I understand what you want to say. However, I think it's better to adapt to it because RUBY is used by convention.

[r7kamura]

Okay, certainly it is more important thing.
Thanks for having the courage to point this out 👍

[koic]

This looks good to me. Can you squash your commits into one?

[koic]

Thanks!