Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #425] Fix a false positive for`Performance/StringIdentifierArgument #430

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

Earlopain
Copy link
Contributor

As per my findings in #427 (comment)

I updated docs with string interpolation with an explicit example. It's not quite like the initial issue report where the colon came from the variable but it should get the point across.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@Earlopain Earlopain requested a review from koic January 3, 2024 17:09
@koic koic merged commit cbc1dd5 into rubocop:master Jan 4, 2024
13 checks passed
@koic
Copy link
Member

koic commented Jan 4, 2024

Thanks!

@Earlopain Earlopain deleted the fix-425 branch February 29, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants