Improve explanation for safety of MapCompact
autocorrection in docs
#450
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I first read about the
Performance/MapCompact
cop, I didn't understand the following sentence at first glance:that
in this sentence is confusing me grammatically-wise.filter_map
as well (see the Ruby docs). Compare that withcompact
, which only gets rid ofnil
values.This fixes #280. The issue was already closed, however, it "fixes" it in the sense that the underlying confusion should be mitigated by a better wording in the docs.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists). -> ⚠ I've included the related issue it in the PR message as well as in the changelog entry. I forgot to add it to the commit message itself, hope that's ok.master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.🛑 As a sidenote: Note that in the last checklist item, you're linking to the contribution guide of rubocop (via the changelog entry format link), not that of this repo.