Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a random test failure for Performance/Sum #458

Merged
merged 1 commit into from
Aug 22, 2024

Commits on Aug 21, 2024

  1. Fix a random test failure for Performance/Sum

    The skipped tests fail with the following command:
    `bundle exec rspec ./spec/rubocop/cli/autocorrect_spec.rb[1:1] ./spec/rubocop/cop/performance/sum_spec.rb[1:13] --seed 26805`
    
    This is fine to do in the rubocop main repository but here we inject
    additional config values that are not restored.
    
    There are some things going on that I don't entirely understand:
    * Why only failures in this one file
    * Why did koic not manage to reproduce with the exact same seed
    * Why did the failures seemingly disappear and reappear without any changes to the code
    
    But regardless, this is more correct
    Earlopain committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    12009a6 View commit details
    Browse the repository at this point in the history