Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress RuboCop offenses #46

Merged
merged 1 commit into from
May 2, 2019
Merged

Conversation

koic
Copy link
Member

@koic koic commented May 2, 2019

Follow up rubocop/rubocop#6954.

This PR applied rubocop --auto-gen-config.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Follow up rubocop/rubocop#6954.

This PR applied `rubocop --auto-gen-config`.
@koic koic merged commit a10ccf8 into rubocop:master May 2, 2019
@koic koic deleted the suppress_rubocop_offense branch May 2, 2019 21:48
@koic
Copy link
Member Author

koic commented May 2, 2019

This PR CI failed but will solved by #47.

@@ -1,11 +1,20 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2019-03-13 01:21:08 +0900 using RuboCop version 0.65.0.
# on 2019-05-01 18:41:27 -0500 using RuboCop version 0.68.1.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if RuboCop just used UTC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants