Remove SafeMode from Count and Detect

[rrosenblum]

This is in response to #69. As noted in the issue, SafeMode has outlived its usefulness. Making use of being disabled by default or setting this as unsafe for auto-correction make more sense.

I have left in the functionality that automatically disables these cops when the Rails cops are enabled. I'm not sure if that is functionality that we would like to maintain or not. These are the only 2 cops that function this way. If we remove the functionality, we can remove the SafeMode module from the core project.

[koic]

I have left in the functionality that automatically disables these cops when the Rails cops are enabled. I'm not sure if that is functionality that we would like to maintain or not.

Yeah, I'd like to investigate whether rails? method can be removed. Anyway, I agree with SafeMode should be replaced by SafeAutoCorrect.

[rrosenblum]

Yeah, I'd like to investigate whether rails? method can be removed.

I think there is an argument for removing it based on having SafeAutoCorrect set to false and having the reasons why it is considered unsafe being well documented.

[rrosenblum]

Should I update the VersionChanged on these cops?

[bbatsov]

Yes.

[rrosenblum]

@bbatsov what are your thoughts on removing the rails? method in favor of SafeAutoCorrect: false and documentation on why it is unsafe?

[bbatsov]

That sounds like a good approach to me. Let's make it happen!

[rrosenblum]

Cool, I'll update this code to remove the rails? check. I'll then create a PR that removes the SafeMode module from RuboCop core.

[rrosenblum]

@koic this is ready for review again.