Add new Rails/MigrationTimestamp cop

This cop enforces that migration file names start with a valid
timestamp in the past.

changelog/new_add_new_rails_migration_timestamp_cop.md

@@ -0,0 +1 @@
+* [#1044](https://github.com/rubocop/rubocop-rails/pull/1044): Add new `Rails/MigrationTimestamp` cop. ([@sambostock][])

config/default.yml

@@ -656,6 +656,13 @@ Rails/MigrationClassName:
   Include:
     - db/**/*.rb
 
+Rails/MigrationTimestamp:
+  Description: 'Checks that migration filenames start with a valid timestamp in the past.'
+  Enabled: pending
+  VersionAdded: '<<next>>'
+  Include:
+    - db/migrate/**/*.rb
+
 Rails/NegateInclude:
   Description: 'Prefer `collection.exclude?(obj)` over `!collection.include?(obj)`.'
   StyleGuide: 'https://rails.rubystyle.guide#exclude'

lib/rubocop/cop/rails/migration_timestamp.rb

@@ -0,0 +1,63 @@
+# frozen_string_literal: true
+
+require 'time'
+
+module RuboCop
+  module Cop
+    module Rails
+      # Checks that migration file names start with a valid timestamp.
+      #
+      # @example
+      #   # bad
+      #   # db/migrate/bad.rb
+
+      #   # bad
+      #   # db/migrate/123_bad.rb
+
+      #   # bad
+      #   # db/migrate/20171301000000_bad.rb
+      #
+      #   # good
+      #   # db/migrate/20170101000000_good.rb
+      #
+      class MigrationTimestamp < Base
+        include RangeHelp
+
+        MSG = 'Migration file name must start with a valid `YYYYmmddHHMMSS_` timestamp in the past.'
+
+        def on_new_investigation
+          file_path = processed_source.file_path
+          return unless file_path.include?('db/migrate')
+
+          timestamp = File.basename(file_path).split('_', 2).first
+          return if valid_timestamp?(timestamp)
+
+          add_offense(source_range(processed_source.buffer, 1, 0))
+        end
+
+        private
+
+        def valid_timestamp?(timestamp)
+          format =                    '%Y%m%d%H%M%S'
+          format_with_utc_suffix =    '%Y%m%d%H%M%S %Z'
+          timestamp_with_utc_suffix = "#{timestamp} UTC"
+
+          timestamp &&
+            # Time.strptime has no way to externally declare what timezone the string is in, so we append it.
+            (time = Time.strptime(timestamp_with_utc_suffix, format_with_utc_suffix)) &&
+            # Time.strptime fuzzily accepts invalid dates around boundaries
+            #          | Wrong Days per Month | 24th Hour      | 60th Minute    | 60th Second
+            # ---------+----------------------+----------------+----------------+----------------
+            # Actual   |       20000231000000 | 20000101240000 | 20000101006000 | 20000101000060
+            # Expected |       20000302000000 | 20000102000000 | 20000101010000 | 20000101000100
+            # We want normalized values, so we can check if Time#strftime matches the original.
+            time.strftime(format) == timestamp &&
+            # No timestamps in the future
+            time <= Time.now.utc
+        rescue ArgumentError
+          false
+        end
+      end
+    end
+  end
+end

lib/rubocop/cop/rails_cops.rb

@@ -73,6 +73,7 @@
 require_relative 'rails/mailer_name'
 require_relative 'rails/match_route'
 require_relative 'rails/migration_class_name'
+require_relative 'rails/migration_timestamp'
 require_relative 'rails/negate_include'
 require_relative 'rails/not_null_column'
 require_relative 'rails/order_by_id'

spec/rubocop/cop/rails/migration_timestamp_spec.rb

@@ -0,0 +1,80 @@
+# frozen_string_literal: true
+
+RSpec.describe RuboCop::Cop::Rails::MigrationTimestamp, :config do
+  it 'registers no offenses if timestamp is valid' do
+    expect_no_offenses(<<~RUBY, 'db/migrate/20170101000000_good.rb')
+      # ...
+    RUBY
+  end
+
+  it 'registers an offense if timestamp is impossible' do
+    expect_offense(<<~RUBY, 'db/migrate/20002222222222_bad.rb')
+      # ...
+      ^ Migration file name must start with a valid `YYYYmmddHHMMSS_` timestamp in the past.
+    RUBY
+  end
+
+  it 'registers an offense if timestamp swaps month and day' do
+    expect_offense(<<~RUBY, 'db/migrate/20003112000000_bad.rb')
+      # ...
+      ^ Migration file name must start with a valid `YYYYmmddHHMMSS_` timestamp in the past.
+    RUBY
+  end
+
+  it 'registers an offense if timestamp day is wrong' do
+    expect_offense(<<~RUBY, 'db/migrate/20000231000000_bad.rb')
+      # ...
+      ^ Migration file name must start with a valid `YYYYmmddHHMMSS_` timestamp in the past.
+    RUBY
+  end
+
+  it 'registers an offense if timestamp hours are invalid' do
+    expect_offense(<<~RUBY, 'db/migrate/20000101240000_bad.rb')
+      # ...
+      ^ Migration file name must start with a valid `YYYYmmddHHMMSS_` timestamp in the past.
+    RUBY
+  end
+
+  it 'registers an offense if timestamp minutes are invalid' do
+    expect_offense(<<~RUBY, 'db/migrate/20000101006000_bad.rb')
+      # ...
+      ^ Migration file name must start with a valid `YYYYmmddHHMMSS_` timestamp in the past.
+    RUBY
+  end
+
+  it 'registers an offense if timestamp seconds are invalid' do
+    expect_offense(<<~RUBY, 'db/migrate/20000101000060_bad.rb')
+      # ...
+      ^ Migration file name must start with a valid `YYYYmmddHHMMSS_` timestamp in the past.
+    RUBY
+  end
+
+  it 'registers an offense if timestamp is invalid' do
+    expect_offense(<<~RUBY, 'db/migrate/123_bad.rb')
+      # ...
+      ^ Migration file name must start with a valid `YYYYmmddHHMMSS_` timestamp in the past.
+    RUBY
+  end
+
+  it 'registers an offense if no timestamp at all' do
+    expect_offense(<<~RUBY, 'db/migrate/bad.rb')
+      # ...
+      ^ Migration file name must start with a valid `YYYYmmddHHMMSS_` timestamp in the past.
+    RUBY
+  end
+
+  it 'registers an offense if the timestamp is in the future' do
+    timestamp = (Time.now.utc + 5).strftime('%Y%m%d%H%M%S')
+    expect_offense(<<~RUBY, "db/migrate/#{timestamp}_bad.rb")
+      # ...
+      ^ Migration file name must start with a valid `YYYYmmddHHMMSS_` timestamp in the past.
+    RUBY
+  end
+
+  it 'registers no offense if the timestamp is in the past' do
+    timestamp = (Time.now.utc - 5).strftime('%Y%m%d%H%M%S')
+    expect_no_offenses(<<~RUBY, "db/migrate/#{timestamp}_good.rb")
+      # ...
+    RUBY
+  end
+end