Exclude File.join from Rails/RootPathnameMethods target methods

rubocop · May 9, 2023 · 6465378 · 6465378
1 parent 24ff064
commit 6465378
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/changelog/change_exclude_file_join_from_rails_root_pathname_methods.md b/changelog/change_exclude_file_join_from_rails_root_pathname_methods.md
@@ -0,0 +1 @@
+* [#1001](https://github.com/rubocop/rubocop-rails/pull/1001): Exclude `File.join` from `Rails/RootPathnameMethods` target methods. ([@r7kamura][])
diff --git a/lib/rubocop/cop/rails/root_pathname_methods.rb b/lib/rubocop/cop/rails/root_pathname_methods.rb
@@ -65,7 +65,6 @@ class RootPathnameMethods < Base
           fnmatch?
           ftype
           grpowned?
-          join
           lchmod
           lchown
           lstat

diff --git a/spec/rubocop/cop/rails/root_pathname_methods_spec.rb b/spec/rubocop/cop/rails/root_pathname_methods_spec.rb
@@ -191,4 +191,10 @@
       file = Rails.root.join('docs', 'invoice.pdf').open
     RUBY
   end
+
+  it 'does not register an offense when using `File.join(Rails.root, ...)`' do
+    expect_no_offenses(<<~RUBY)
+      File.join(Rails.root, '/foo')
+    RUBY
+  end
 end
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		* [#1001](https://github.com/rubocop/rubocop-rails/pull/1001): Exclude `File.join` from `Rails/RootPathnameMethods` target methods. ([@r7kamura][])
-Original file line number
+Diff line change
@@ Expand Up / @@ -65,7 +65,6 @@ class RootPathnameMethods < Base @@
               fnmatch?
               ftype
               grpowned?
-              join
               lchmod
               lchown
               lstat
@@ Expand Down @@