Merge pull request #1009 from fatkodima/i18n_locale_texts-flash_now

Support `flash.now` for `Rails/I18nLocaleTexts`
rubocop · May 26, 2023 · b70b1d8 · b70b1d8
2 parents d45d052 + b2bb010
commit b70b1d8
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/changelog/change_support_flash_now_for.md b/changelog/change_support_flash_now_for.md
@@ -0,0 +1 @@
+* [#1007](https://github.com/rubocop/rubocop-rails/issues/1007): Support `flash.now` for `Rails/I18nLocaleTexts`. ([@fatkodima][])
diff --git a/lib/rubocop/cop/rails/i18n_locale_texts.rb b/lib/rubocop/cop/rails/i18n_locale_texts.rb
@@ -80,7 +80,11 @@ class I18nLocaleTexts < Base
         PATTERN
 
         def_node_matcher :flash_assignment?, <<~PATTERN
-          (send (send nil? :flash) :[]= _ $str)
+          (send
+            {
+              (send nil? :flash)
+              (send (send nil? :flash) :now)
+            } :[]= _ $str)
         PATTERN
 
         def_node_search :mail_subject, <<~PATTERN

diff --git a/spec/rubocop/cop/rails/i18n_locale_texts_spec.rb b/spec/rubocop/cop/rails/i18n_locale_texts_spec.rb
@@ -52,6 +52,19 @@
     RUBY
   end
 
+  it 'registers an offense when assigning to `flash.now` text messages' do
+    expect_offense(<<~RUBY)
+      flash.now[:notice] = "Post created!"
+                           ^^^^^^^^^^^^^^^ Move locale texts to the locale files in the `config/locales` directory.
+    RUBY
+  end
+
+  it 'does not register an offense when assigning to `flash.now` localized messages' do
+    expect_no_offenses(<<~RUBY)
+      flash.now[:notice] = t(".success")
+    RUBY
+  end
+
   it 'registers an offense when using `mail` with text subject' do
     expect_offense(<<~RUBY)
       mail(to: user.email, subject: "Welcome to My Awesome Site")