Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Rails/WhereEquals aware of where.not #1199

Closed
ydakuka opened this issue Dec 3, 2023 · 0 comments · Fixed by #1323
Closed

Make Rails/WhereEquals aware of where.not #1199

ydakuka opened this issue Dec 3, 2023 · 0 comments · Fixed by #1323
Labels
enhancement New feature or request

Comments

@ydakuka
Copy link

ydakuka commented Dec 3, 2023

Describe the solution you'd like

# bad
def my_method
  User.where.not('name = ?', 'Gabe')
end

Rubocop

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.58.0 (using Parser 3.2.2.4, rubocop-ast 1.30.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.19.0
  - rubocop-factory_bot 2.24.0
  - rubocop-performance 1.19.1
  - rubocop-rails 2.22.2
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.25.0
  - rubocop-thread_safety 0.5.1
@ydakuka ydakuka changed the title Make Rails/WhereEquals aware of where.not Make Rails/WhereEquals aware of where.not Dec 3, 2023
@koic koic added the enhancement New feature or request label Dec 4, 2023
Earlopain added a commit to Earlopain/rubocop-rails that referenced this issue Aug 10, 2024
This copies a bit of logic from `WhereRange` but they need slighly
different handling and it doesn't seem worth to extract yet.
Earlopain added a commit to Earlopain/rubocop-rails that referenced this issue Aug 10, 2024
This copies a bit of logic from `WhereRange` but they need slighly
different handling and it doesn't seem worth to extract yet.
@koic koic closed this as completed in 3885fcc Aug 15, 2024
koic added a commit that referenced this issue Aug 15, 2024
[Fix #1199] Make `Rails/WhereEquals` aware of `where.not(...)`
koic pushed a commit to koic/rubocop-rails that referenced this issue Aug 23, 2024
This copies a bit of logic from `WhereRange` but they need slighly
different handling and it doesn't seem worth to extract yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants